Changeset 9532

Timestamp:

5 Nov 2012, 07:19:54 (12 years ago)

Author:

Henrik Bettermann

Message:

Limit the total number of credits per level.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/students

Files:

• browser.py (modified) (3 diffs)
• interfaces.py (modified) (1 diff)
• studylevel.py (modified) (1 diff)
• tests/test_browser.py (modified) (2 diffs)
• utils.py (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/students/browser.py

@@ -1224 +1224 @@
     @action(_('Add course ticket'))
     def addCourseTicket(self, **data):
+        students_utils = getUtility(IStudentsUtils)
         ticket = createObject(u'waeup.CourseTicket')
         course = data['course']
         ticket.automatic = False
         ticket.carry_over = False
+        max_credits = students_utils.maxCreditsExceeded(self.context, course)
+        if max_credits:
+            self.flash(_(
+                'Total credits exceed ${a}.',
+                mapping = {'a': max_credits}))
+            return
         try:
             self.context.addCourseTicket(ticket, course)
@@ -2249 +2256 @@
     @action(_('Add course ticket'))
     def addCourseTicket(self, **data):
+        students_utils = getUtility(IStudentsUtils)
         # Safety belt
         if self.context.student.state != PAID:
@@ -2256 +2264 @@
         ticket.automatic = False
         ticket.carry_over = False
+        max_credits = students_utils.maxCreditsExceeded(self.context, course)
+        if max_credits:
+            self.flash(_(
+                'Your total credits exceed ${a}.',
+                mapping = {'a': max_credits}))
+            return
         try:
             self.context.addCourseTicket(ticket, course)

main/waeup.kofa/trunk/src/waeup/kofa/students/interfaces.py

@@ -464 +464 @@
     certcode = Attribute('The certificate code of the study course')
     is_current_level = Attribute('Is this level the current level of the student?')
+    total_credits = Attribute('Total of all ticket credits in this study level.')
 
     level_session = schema.Choice(

main/waeup.kofa/trunk/src/waeup/kofa/students/studylevel.py

@@ -59 +59 @@
 
     @property
+    def total_credits(self):
+        total = 0
+        for ticket in self.values():
+            total += ticket.credits
+        return total
+
+    @property
     def is_current_level(self):
         try:

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_browser.py

@@ -725 +725 @@
         self.browser.getControl("Add course ticket").click()
         self.browser.getControl(name="form.course").value = ['COURSE1']
+        self.course.credits = 100
+        self.browser.getControl("Add course ticket").click()
+        self.assertMatches(
+            '...Total credits exceed 58...', self.browser.contents)
+        self.course.credits = 10
         self.browser.getControl("Add course ticket").click()
         self.assertTrue('Successfully added' in self.browser.contents)
@@ -1873 +1878 @@
         self.browser.getControl("Add course ticket").click()
         self.browser.getControl(name="form.course").value = ['COURSE1']
+        self.course.credits = 100
+        self.browser.getControl("Add course ticket").click()
+        self.assertMatches(
+            '...Your total credits exceed 58...', self.browser.contents)
+        self.course.credits = 10
         self.browser.getControl("Add course ticket").click()
         self.assertMatches('...The ticket exists...',

main/waeup.kofa/trunk/src/waeup/kofa/students/utils.py

@@ -573 +573 @@
         return pdf_stream
 
+    TOTAL_CREDITS = 58
+
+    def maxCreditsExceeded(self, studylevel, course):
+        if self.TOTAL_CREDITS and \
+            studylevel.total_credits + course.credits > self.TOTAL_CREDITS:
+            return self.TOTAL_CREDITS
+        return 0
+
     VERDICTS_DICT = {
         '0': _('(not yet)'),