Changeset 9531

Timestamp:

4 Nov 2012, 21:51:57 (12 years ago)

Author:

Henrik Bettermann

Message:

Log changes when saving ApplicantsContainerManageFormPage?.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/applicants

Files:

• browser.py (modified) (2 diffs)
• container.py (modified) (1 diff)
• interfaces.py (modified) (1 diff)
• tests/test_browser.py (modified) (2 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/browser.py

@@ -397 +397 @@
     @action(_('Save'), style='primary')
     def save(self, **data):
-        self.applyData(self.context, **data)
+        changed_fields = self.applyData(self.context, **data)
+        if changed_fields:
+            changed_fields = reduce(lambda x,y: x+y, changed_fields.values())
+        else:
+            changed_fields = []
         self.context.description_dict = self._description()
         # Always refresh title. So we can change titles
@@ -406 +410 @@
             title, self.context.year, self.context.year + 1)
         self.flash(_('Form has been saved.'))
+        fields_string = ' + '.join(changed_fields)
+        self.context.writeLogMessage(self, 'saved: % s' % fields_string)
         return
 

main/waeup.kofa/trunk/src/waeup/kofa/applicants/container.py

@@ -113 +113 @@
         return False
 
+    def writeLogMessage(self, view, message):
+        ob_class = view.__implemented__.__name__.replace('waeup.kofa.','')
+        self.__parent__.logger.info(
+            '%s - %s - %s' % (ob_class, self.code, message))
+        return
 
 ApplicantsContainer = attrs_to_fields(ApplicantsContainer)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/interfaces.py

@@ -290 +290 @@
         """
 
+    def writeLogMessage(view, comment):
+        """Adds an INFO message to the log file
+        """
+
 class IApplicantsContainerAdd(IApplicantsContainer):
     """An applicants container contains university applicants.

main/waeup.kofa/trunk/src/waeup/kofa/applicants/tests/test_browser.py

@@ -19 +19 @@
 Test the applicant-related UI components.
 """
+import os
 import pytz
 import shutil
@@ -370 +371 @@
         self.assertEqual(self.browser.headers['Status'], '200 Ok')
         self.assertEqual(self.browser.url, self.manage_container_path)
+        self.browser.getControl(name="form.application_fee").value = '200'
         self.browser.getControl("Save").click()
         self.assertTrue('Form has been saved' in self.browser.contents)
+        logfile = os.path.join(
+            self.app['datacenter'].storage, 'logs', 'applicants.log')
+        logcontent = open(logfile).read()
+        self.assertTrue(
+            'zope.mgr - applicants.browser.ApplicantsContainerManageFormPage - '
+            'app2010 - saved: application_fee\n' in logcontent)
         self.browser.getControl("Remove selected", index=0).click()
         self.assertTrue('No applicant selected' in self.browser.contents)