Changeset 7522 for main/waeup.sirp/trunk/src/waeup/sirp/students/batching.py

Timestamp:

27 Jan 2012, 16:33:02 (13 years ago)

Author:

Henrik Bettermann

Message:

Add history messages and log file entries when importing students.

Do not accept empty reg_state fields. If the the reg_state column exists a valid value must be provided.

File:

• main/waeup.sirp/trunk/src/waeup/sirp/students/batching.py (modified) (5 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/students/batching.py

@@ -33 +33 @@
 from hurry.workflow.interfaces import IWorkflowState
 from waeup.sirp.interfaces import (
-    IBatchProcessor, FatalCSVError, IObjectConverter, IUserAccount)
+    IBatchProcessor, FatalCSVError, IObjectConverter, IUserAccount,
+    IObjectHistory)
 from waeup.sirp.students.interfaces import (
     IStudent, IStudentStudyCourseImport,
@@ -39 +40 @@
 from waeup.sirp.students.workflow import  IMPORTABLE_STATES
 from waeup.sirp.utils.batching import BatchProcessor
+from waeup.sirp.utils.helpers import get_current_principal
 
 class StudentProcessor(BatchProcessor):
@@ -131 +133 @@
         parent = self.getParent(row, site)
         parent.addStudent(obj)
+        # In some tests we don't have a students container or a user
+        try:
+            user = get_current_principal()
+            parent.logger.info('%s - %s - Student record imported' % (
+                user.id,obj.student_id))
+            history = IObjectHistory(obj)
+            history.addMessage('Student record imported')
+        except (TypeError, AttributeError):
+            pass
         return
 
@@ -145 +156 @@
         for key, value in row.items():
             # Set student password and all fields declared in interface.
-            if key == 'password':
+            if key == 'password' and value != '':
                 IUserAccount(obj).setPassword(value)
             elif key == 'reg_state':
                 IWorkflowState(obj).setState(value)
+                msg = "State '%s' set" % value
+                history = IObjectHistory(obj)
+                history.addMessage(msg)
             elif hasattr(obj, key):
                 setattr(obj, key, value)
@@ -183 +197 @@
             row, self.factory_name)
         if row.has_key('reg_state') and \
-            row['reg_state'] is not None and \
             not row['reg_state'] in IMPORTABLE_STATES:
-            errs.append(('reg_state','not allowed'))
+            if row['reg_state'] != '':
+                errs.append(('reg_state','not allowed'))
+            else:
+                errs.append(('reg_state','no value provided'))
         return errs, inv_errs, conv_dict