Changeset 6790 for main/waeup.sirp/trunk/src/waeup/sirp/students/browser.py

Timestamp:

18 Sep 2011, 00:26:48 (13 years ago)

Author:

uli

Message:

Make password setting a bit better readable.

File:

• main/waeup.sirp/trunk/src/waeup/sirp/students/browser.py (modified) (1 diff)

main/waeup.sirp/trunk/src/waeup/sirp/students/browser.py

@@ -343 +343 @@
         form = self.request.form
         ob_class = self.__implemented__.__name__.replace('waeup.sirp.','')
-        if form.has_key('password') and form['password']:
-            if form['password'] != form['control_password']:
+        password = form.get('password', None)
+        password_ctl = form.get('control_password', None)
+        if password:
+            if (password != password_ctl):
                 self.flash('Passwords do not match.')
-                return
-            IUserAccount(self.context).setPassword(form['password'])
-            self.context.loggerInfo(ob_class, 'password changed')
+            else:
+                # XXX: This is too early. PW should only be saved if there
+                #      are no (other) errors left in form.
+                IUserAccount(self.context).setPassword(password)
+                self.context.loggerInfo(ob_class, 'password changed')
+
         #self.reg_number = form.get('form.reg_number', None)
         #if self.reg_number: