Changeset 6273 for main/waeup.sirp/trunk/src/waeup/sirp/utils/batching.py

Timestamp:

4 Jun 2011, 02:29:21 (13 years ago)

Author:

uli

Message:

Finally make the new converter work. API-wise it is as good as the old one (can import everyting, the old one could),
but design-wise it might be much more powerfull. Basically it can handle/convert all content-types for which one can
create an Add- or EditForm? successfully. In other words: if you manage to write an edit form for some content type,
then you can also create an importer for that content-type. Still finetuning needed (for dates, bool data, etc.) but
the main things work.

File:

• main/waeup.sirp/trunk/src/waeup/sirp/utils/batching.py (modified) (5 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/utils/batching.py

@@ -15 +15 @@
 from zope.schema import getFields
 from waeup.sirp.interfaces import (
-    IBatchProcessor, ISchemaTypeConverter, FatalCSVError, DuplicationError)
+    IBatchProcessor, ISchemaTypeConverter, FatalCSVError, DuplicationError,
+    IObjectConverter)
 
 class BatchProcessor(grok.GlobalUtility):
@@ -149 +150 @@
                     warnings.append(msg)
         return (row, warnings)
+
+    def stringFromErrs(self, errors, inv_errors):
+        result = []
+        for err in errors:
+            fieldname, message = err
+            result.append("%s: %s" % (fieldname, message))
+        for err in inv_errors:
+            result.append("invariant: %s" % err)
+        return '; '.join(result)
 
     def callFactory(self, *args, **kw):
@@ -239 +249 @@
         temp_dir = tempfile.mkdtemp()
 
-        (base, ext) = os.path.splitext(path)
+        base = os.path.basename(path)
+        (base, ext) = os.path.splitext(base)
         failed_path = os.path.join(temp_dir, "%s.pending%s" % (base, ext))
         failed_headers = mapping.keys()
@@ -258 +269 @@
         num_warns = 0
         site = grok.getSite()
+        converter = IObjectConverter(self.iface)
         for raw_row in reader:
             num += 1
             string_row = self.applyMapping(raw_row, mapping)
-            row, conv_warnings = self.convertToTypes(
-                copy.deepcopy(string_row), converters)
-            if len(conv_warnings):
+            row = dict(string_row.items()) # create deep copy
+            errs, inv_errs, conv_dict =  converter.fromStringDict(
+                string_row, self.factory_name)
+            if errs or inv_errs:
                 num_warns += 1
-                self.writeFailedRow(failed_writer, raw_row, conv_warnings)
+                conv_warnings = self.stringFromErrs(errs, inv_errs)
+                self.writeFailedRow(
+                    failed_writer, raw_row, conv_warnings)
                 continue
+            row.update(conv_dict)
 
             if mode == 'create':
@@ -286 +302 @@
                 try:
                     self.addEntry(obj, row, site)
-                except DuplicationError, error:
-                    num_warns += 1
-                    self.writeFailedRow(
-                        failed_writer, raw_row,
-                        "%s Skipping." % error.msg)
+                except KeyError, error:
+                    num_warns += 1
+                    self.writeFailedRow(
+                        failed_writer, raw_row,
+                        "%s Skipping." % error.message)
                     continue
             elif mode == 'remove':