Changeset 17546 for main/kofacustom.iuokada/trunk/src/kofacustom/iuokada/students/browser.py

Timestamp:

17 Aug 2023, 07:43:50 (13 months ago)

Author:

Henrik Bettermann

Message:

Fix school fees summary.

File:

• main/kofacustom.iuokada/trunk/src/kofacustom/iuokada/students/browser.py (modified) (2 diffs)

main/kofacustom.iuokada/trunk/src/kofacustom/iuokada/students/browser.py

@@ -265 +265 @@
         SF_PAYMENTS = ('schoolfee', 'schoolfee40', 'secondinstal', 'clearance')
         sf_paid = dict()
-        session = self.context.student.entry_session
-        while session < cs + 2:
-            sf_paid[session] = 0.0
-            session += 1
-        sessions = sf_paid.keys()
         try:
             certificate = self.context.student['studycourse'].certificate
         except (AttributeError, TypeError):
-            return sf_paid, 0, 0
-        total_sf = 0.0
-        if self.context.student in (ADMITTED, CLEARANCE, REQUESTED, CLEARED):
-            sf = getattr(certificate, 'school_fee_1', 0.0)
-        else:
-            sf = getattr(certificate, 'school_fee_2', 0.0)
-        if sf is not None:
-            total_sf = sf
+            return sf_paid, 0
+        session = self.context.student.entry_session
+        # Initiliaze sf_paid dict with items
+        # session: [school fee in session,, amount paid in session, amount due]
+        sf_paid[session] = [getattr(certificate, 'school_fee_1', 0.0), 0.0, 0.0]
+        while session < cs + 1:
+            session += 1
+            sf_paid[session]= [getattr(certificate, 'school_fee_2', 0.0), 0.0, 0.0]
+        sessions = sf_paid.keys()
         brought_fwd = 0.0
+        # Collect all payments made or brought forward
         for ticket in self.context.values():
             amt = ticket.net_amt
@@ -289 +286 @@
                 ticket.p_state == 'paid' and \
                 ticket.p_session in sessions:
-                sf_paid[ticket.p_session] += amt
+                sf_paid[ticket.p_session][1] += amt
             if ticket.p_state != 'paid' and\
                ticket.p_category == 'brought_fwd':
                   brought_fwd += ticket.amount_auth
-        return sorted(sf_paid.items(), key=lambda value: value[0]), total_sf, brought_fwd
+        # Calculate due, first entry session
+        entry_session = sessions[0]
+        #   amount due in session =  brought forward from previous sessions + school fee in session - amount paid in session
+        sf_paid[entry_session][2] = brought_fwd + sf_paid[entry_session][0] - sf_paid[entry_session][1]
+        for session in sessions[1:]:
+            #   amount due in session =  brought forward from previous session + school fee in session - amount paid in session
+            sf_paid[session][2] = sf_paid[session-1][2] + sf_paid[session][0] - sf_paid[session][1]
+        return sorted(sf_paid.items(), key=lambda value: value[0]), brought_fwd
 
     def update(self):