Changeset 15932 for main/waeup.kofa/trunk/src/waeup/kofa/applicants/applicant.py

Timestamp:

16 Jan 2020, 11:04:43 (5 years ago)

Author:

Henrik Bettermann

Message:

Reset _curr_stud_id if student could not be created.

File:

• main/waeup.kofa/trunk/src/waeup/kofa/applicants/applicant.py (modified) (5 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/applicant.py

@@ -156 +156 @@
         and copy applicant data.
         """
+        site = grok.getSite()
         # Is applicant in the correct state?
         if self.state != 'admitted':
@@ -164 +165 @@
             student.reg_number = self.reg_number
         except RegNumNotInSource:
+            # Reset _curr_stud_id 
+            site['students']._curr_stud_id -= 1
             return False, _('Registration Number exists.')
         # Has the course_admitted field been properly filled?
         if self.course_admitted is None:
+            # Reset _curr_stud_id
+            site['students']._curr_stud_id -= 1
             return False, _('No course admitted provided.')
         # Set student attributes
@@ -173 +178 @@
                 setattr(student, item[1], getattr(self, item[0], None))
         except RequiredMissing, err:
+            site['students']._curr_stud_id -= 1
             return False, 'RequiredMissing: %s' % err
         except:
+            site['students']._curr_stud_id -= 1
             return False, 'Unknown Error'
         # Prove if the certificate still exists
@@ -180 +187 @@
             StudentStudyCourse().certificate = self.course_admitted
         except ConstraintNotSatisfied, err:
+            # Reset _curr_stud_id
+            site['students']._curr_stud_id -= 1
             return False, 'ConstraintNotSatisfied: %s' % self.course_admitted.code
         # Finally prove if an application slip can be created
@@ -186 +195 @@
                 view=view)
         except IOError:
+            site['students']._curr_stud_id -= 1
             return False, _('IOError: Application Slip could not be created.')
         except LayoutError, err:
+            site['students']._curr_stud_id -= 1
             return False, _('Reportlab LayoutError: %s' % err)
         except AttributeError, err:
+            site['students']._curr_stud_id -= 1
             return False, _('Reportlab AttributeError: ${a}', mapping = {'a':err})
         except:
+            site['students']._curr_stud_id -= 1
             return False, _('Unknown Reportlab error')
         # Add student
-        site = grok.getSite()
         site['students'].addStudent(student)
         # Save student_id