Changeset 12623 for main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_batching.py

Timestamp:

18 Feb 2015, 12:36:02 (10 years ago)

Author:

Henrik Bettermann

Message:

StudentOnlinePaymentProcessor?: Raise DuplicationError? if payment
(in state paid) with same p_session and p_category exists.

See ticket Uniben #970.

File:

• main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_batching.py (modified) (6 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_batching.py

@@ -34 +34 @@
 
 from waeup.kofa.app import University
-from waeup.kofa.interfaces import IBatchProcessor, FatalCSVError, IUserAccount
+from waeup.kofa.interfaces import (
+    IBatchProcessor, FatalCSVError, IUserAccount, DuplicationError)
 from waeup.kofa.students.batching import (
     StudentProcessor, StudentStudyCourseProcessor,
@@ -982 +983 @@
         payment = createObject(u'waeup.StudentOnlinePayment')
         payment.p_id = 'p120'
+        payment.p_session = 2012
+        payment.p_category = 'schoolfee'
+        payment.p_state = 'paid'
         self.student['payments'][payment.p_id] = payment
 
@@ -1046 +1050 @@
         self.assertEqual(len(self.student['payments'].keys()),3)
         self.assertEqual(self.student['payments']['p560'].p_id, 'p560')
+        # Requirement added on 19/02/2015: same payment must not exist.
+        payment3 = createObject(u'waeup.StudentOnlinePayment')
+        payment3.p_id = 'p456'
+        payment3.p_session = 2012
+        payment3.p_category = 'schoolfee'
+        self.assertRaises(
+            DuplicationError, self.processor.addEntry, payment3,
+            dict(student_id=self.student.student_id, p_id='p456'), self.app)
 
     def test_checkConversion(self):
@@ -1110 +1122 @@
             'p_item=BTECHBDT, creation_date=2010-02-15 13:19:01+00:00, '
             'p_category=schoolfee, amount_auth=19500.0, p_current=True, '
+            'p_session=2009, '
             'p_id=p1266236341955, r_code=00, r_amount_approved=19500.0, '
             'p_state=paid'
@@ -1118 +1131 @@
             'p_item=BTECHBDT, creation_date=2010-02-15 13:19:01+00:00, '
             'p_category=schoolfee, amount_auth=19500.6, p_current=True, '
+            'p_session=2011, '
             'p_id=ABC-11-1234567890, r_code=SC, r_amount_approved=19500.0, '
             'p_state=paid'
@@ -1153 +1167 @@
         num, num_warns, fin_file, fail_file = self.processor.doImport(
             self.csv_file2, PAYMENT_CREATE_HEADER_FIELDS,'create')
-        self.assertEqual(num_warns,0)
-        shutil.rmtree(os.path.dirname(fin_file))
-        self.assertEqual(len(self.app['students']['X666666']['payments']), 50)
+        # One payment with same session and category exists
+        self.assertEqual(num_warns,1)
+        content = open(fail_file).read()
+        self.assertTrue(
+            '1,942,online,BTECHBDT,2010/11/26 19:59:33.744 GMT+1,0,'
+            '19500,schoolfee,19500,2015,paid,'
+            'Same payment has already been made. Skipping.'
+            in content)
+        shutil.rmtree(os.path.dirname(fin_file))
+        self.assertEqual(len(self.app['students']['X666666']['payments']), 13)
 
 class StudentVerdictProcessorTest(StudentImportExportSetup):