Changeset 12496 for main/waeup.ikoba/trunk/src/waeup/ikoba/payments/paypal.py

Timestamp:

20 Jan 2015, 05:57:59 (10 years ago)

Author:

uli

Message:

Adapt (nice) change in official Paypal API for ICreditCard.

File:

• main/waeup.ikoba/trunk/src/waeup/ikoba/payments/paypal.py (modified) (4 diffs)

main/waeup.ikoba/trunk/src/waeup/ikoba/payments/paypal.py

@@ -300 +300 @@
         )
 
-    payer_id = schema.TextLine(
+    external_customer_id = schema.TextLine(
         title=u'Payer ID',
         description=(u'A unique identifier for the credit card. This '
@@ -390 +390 @@
           data. Required if using a stored credit card.
 
-    `payer_id`: Unique identifier. If none is given, we assign a
-          uuid. The uuid reads 'PAYER_<32 hex digits>'.
+    `external_customer_id`: Unique identifier. If none is given, we
+          assign a uuid. The uuid reads 'PAYER_<32 hex digits>'.
 
     `number`: Credit card number. Numeric characters only with no
@@ -426 +426 @@
     grok.implements(ICreditCard)
 
-    def __init__(self, paypal_id=None, payer_id=None, number=None,
-                 credit_card_type=None, expire_month=1, expire_year=2000,
-                 cvv2=None, first_name=None, last_name=None,
-                 billing_address=None, state=None, paypal_valid_until=None):
+    def __init__(self, paypal_id=None, external_customer_id=None,
+                 number=None, credit_card_type=None, expire_month=1,
+                 expire_year=2000, cvv2=None, first_name=None,
+                 last_name=None, billing_address=None, state=None,
+                 paypal_valid_until=None):
         if not re.match('^[0-9]+$', number):
             raise ValueError("Credit card number may "
                              "not contain non-numbers.")
-        if payer_id is None:
-            payer_id = u'PAYER_' + unicode(uuid.uuid4().hex)
+        if external_customer_id is None:
+            external_customer_id = u'PAYER_' + unicode(uuid.uuid4().hex)
         self.paypal_id = paypal_id
-        self.payer_id = payer_id
+        self.external_customer_id = external_customer_id
         self.number = number
         self.credit_card_type = credit_card_type
@@ -1189 +1190 @@
 
     def create_payment(self, payer, payment_item,  payee=None):
+        """Create a creditcard payment.
+
+        XXX: payer_id is deprecated by paypal: use
+        XXX: external_customer_id instead (also when creating credit cards).
+        XXX: This is a Good Thing(tm) because `payer_id` is already used in
+        XXX: some parts of the API for PayPal-assigned values.
+        """
         if not IPayer.providedBy(payer):
             payer = IPayer(payer)