Changeset 12395 for main/waeup.kofa/trunk/src/waeup/kofa/applicants/applicant.py

Timestamp:

4 Jan 2015, 17:19:06 (10 years ago)

Author:

Henrik Bettermann

Message:

Catch traceback when creating an application slip with a corrupted image file. This error caused a lot of trouble on KwaraPoly?.

File:

• main/waeup.kofa/trunk/src/waeup/kofa/applicants/applicant.py (modified) (2 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/applicant.py

@@ -144 +144 @@
         except:
             return False, 'Unknown Error'
-        # Finally prove if the certificate still exists
+        # Prove if the certificate still exists
         try:
             StudentStudyCourse().certificate = self.course_admitted
         except ConstraintNotSatisfied, err:
             return False, 'ConstraintNotSatisfied: %s' % self.course_admitted.code
+        # Finally prove if an application slip can be created
+        try:
+            applicant_slip = getAdapter(self, IPDF, name='application_slip')(
+                view=view)
+        except IOError:
+            return False, _('IOError: Application Slip could not be created.')
         # Add student
         site = grok.getSite()
@@ -165 +171 @@
         notify(grok.ObjectModifiedEvent(student))
         # Save application slip
-        try:
-            self._createApplicationPDF(student, view=view)
-            return True, _('Student ${a} created', mapping = {'a':student.student_id})
-        except IOError:
-            return False, _('IOError: Application Slip could not be created.')
-
-    def _createApplicationPDF(self, student, view=None):
+        self._saveApplicationPDF(student, applicant_slip, view=view)
+        return True, _('Student ${a} created', mapping = {'a':student.student_id})
+
+    def _saveApplicationPDF(self, student, applicant_slip, view=None):
         """Create an application slip as PDF and store it in student folder.
         """
         file_store = getUtility(IExtFileStore)
-        applicant_slip = getAdapter(self, IPDF, name='application_slip')(
-            view=view)
         file_id = IFileStoreNameChooser(student).chooseName(
             attr="application_slip.pdf")