Changeset 10030 for main/waeup.kofa/trunk/src/waeup/kofa/webservices.py

Timestamp:

17 Mar 2013, 08:40:59 (12 years ago)

Author:

Henrik Bettermann

Message:

Use better class names. The PaymentWebservice? adapter is not a webservice. KofaPaymentRequest? is not a request but a view for a simple web service.

We do not publish the data of the payee but of the payer.

File:

• main/waeup.kofa/trunk/src/waeup/kofa/webservices.py (modified) (3 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/webservices.py

@@ -20 +20 @@
 from zope.component import getUtility
 from zope.catalog.interfaces import ICatalog
-from waeup.kofa.payments.interfaces import IPaymentWebservice
+from waeup.kofa.payments.interfaces import IPayer
 from waeup.kofa.interfaces import IUniversity, academic_sessions_vocab
 
-# Kofa's webservices to requery payments from outside
+class PaymentDataWebservice(grok.View):
+    """A simple webservice to publish payment and payer details on request from
+    accepted IP addresses without authentication.
 
-class KofaPaymentRequest(grok.View):
-
+    """
     grok.context(IUniversity)
     grok.name('paymentrequest')
@@ -40 +41 @@
         real_ip = self.request.get('HTTP_X_FORWARDED_FOR', None)
         if real_ip:
-            self.context.logger.info('KofaPaymentRequest called: %s' % real_ip)
+            self.context.logger.info('PaymentDataWebservice called: %s' % real_ip)
         if real_ip and self.ACCEPTED_IP:
             if real_ip not in  self.ACCEPTED_IP:
@@ -52 +53 @@
             return
         try:
-            owner = IPaymentWebservice(results[0])
+            owner = IPayer(results[0])
             full_name = owner.display_fullname
             reg_number = owner.reg_number