Changeset 9801 for main/waeup.kofa/trunk/src/waeup/kofa/students

Timestamp:

14 Dec 2012, 14:07:55 (12 years ago)

Author:

uli

Message:

get_filtered() now accepts any keyword parameters and can handle catalog queries more properly.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/students

Files:

• export.py (modified) (1 diff)
• interfaces.py (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/students/export.py

@@ -98 +98 @@
         return get_students(x)
 
-    def get_filtered(self, site, current_session=None,
-                     current_level=None, faccode=None, depcode=None, ):
-        query = StudentsQuery(
-            current_session=current_session,
-            current_level=current_level,
-            faccode=faccode, depcode=depcode)
+    def get_filtered(self, site, **kw):
+        """Get students filtered by keywords.
+
+        The keys must be valid students catalog index names. Returns a
+        simple empty list or a catalog result set with `Student`
+        objects.
+
+        .. seealso:: `waeup.kofa.students.catalog.StudentsCatalog`
+
+        """
+        # Pass only given keywords to StudentsQuery. This way we avoid
+        # trouble with `None` value ambivalences and queries are also
+        # faster (normally less indexes to ask). Drawback is, that
+        # developers must look into catalog to see what keywords are
+        # valid.
+        query = StudentsQuery(**kw)
         return query.query()
 

main/waeup.kofa/trunk/src/waeup/kofa/students/interfaces.py

@@ -748 +748 @@
       data from a given student object.
     """
-    def get_filtered(site, current_session=None, current_level=None,
-                     faculty_code=None, department_code=None):
+    def get_filtered(site, **kw):
         """Get a filtered set of students.
         """