Changeset 9673 for main/waeup.kofa/trunk/src/waeup

Timestamp:

17 Nov 2012, 23:43:02 (12 years ago)

Author:

uli

Message:

Remove useless report title.

Location:

main/waeup.kofa/trunk/src/waeup/kofa

Files:

• reports.py (modified) (2 diffs)
• students/reports.py (modified) (2 diffs)
• students/tests/test_reports.py (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/reports.py

@@ -52 +52 @@
     """
     title = Attribute("""Human readable description of report type.""")
+
     def generate(site, args=[], kw={}):
         """Generate a report.
@@ -157 +158 @@
 class Report(object):
     creation_dt = None
-
-    @property
-    def title(self):
-        return _(u'A report')
 
     def __init__(self, args=[], kwargs={}):

main/waeup.kofa/trunk/src/waeup/kofa/students/reports.py

@@ -128 +128 @@
         self.data = get_students_by(session, mode)
 
-    @property
-    def title(self):
-        title = 'StudentsReport_%s_%s_%s' % (
-            self.session, self.mode, self._creation_dt_string)
-        title = title.replace('/', '_').replace(' ','_')
-        return title
-
     def create_pdf(self):
         creator = getUtility(IPDFCreator)
@@ -223 +216 @@
 
     def render(self):
-        filename = "%s.pdf" % (self.context.title)
+        filename = 'StudentsReport_%s_%s_%s.pdf' % (
+            self.context.session, self.context.mode,
+            self._creation_dt_string)
+        filename = filename.replace(
+            '/', '_').replace(' ','_').replace(':', '-')
         self.response.setHeader(
             'Content-Type', 'application/pdf')

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_reports.py

@@ -19 +19 @@
         verifyClass(IStudentsReport, StudentsReport)
         verifyObject(IStudentsReport, obj)
-        return
-
-    def test_title(self):
-        obj = StudentsReport(2010, 'Undergraduate Full-Time', author='Bob')
-        self.assertTrue(
-            obj.title.startswith(
-            'StudentsReport_2010_2011_Undergraduate_Full-Time_'))
         return