Changeset 9565

Timestamp:

7 Nov 2012, 08:27:23 (12 years ago)

Author:

Henrik Bettermann

Message:

Add 'show students' button to CoursePage?.

Lecturers can now list all students in course but they can neither access the students nor the respective course tickets. A CourseTicketPrincipalRoleManager? does not yet exist. And we have to discuss what lecturers are supposed to see. In my opinion, lecturers must no see student data.

Location:

main/waeup.kofa/trunk/src/waeup/kofa

Files:

• browser/pages.py (modified) (3 diffs)
• browser/viewlets.py (modified) (1 diff)
• students/dynamicroles.py (modified) (2 diffs)
• students/tests/test_browser.py (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/browser/pages.py

@@ -62 +62 @@
 
 from waeup.kofa.students.catalog import search as searchstudents
+from waeup.kofa.students.catalog import StudentQueryResultItem
 from waeup.kofa.university.catalog import search
 from waeup.kofa.university.vocabularies import course_levels
@@ -1890 +1891 @@
     """
     grok.context(ICertificate)
-    grok.require('waeup.showStudents')
     grok.name('showcertstudents')
-    pnav = 1
-    label = _('Students')
 
     @property
@@ -1899 +1897 @@
         hitlist = searchstudents(query=self.context.code,
             searchtype='certcode', view=self)
+        return hitlist
+
+class ShowStudentsInCoursePage(ShowStudentsInDepartmentPage):
+    """Page that lists all students studying a certificate.
+    """
+    grok.context(ICourse)
+    grok.name('showcoursestudents')
+
+    @property
+    def getStudents(self):
+        hitlist = []
+        cat = queryUtility(ICatalog, name='coursetickets_catalog')
+        results = cat.searchResults(code=(self.context.code, self.context.code))
+        for result in results:
+            hitlist.append(StudentQueryResultItem(result.student, view=self))
         return hitlist
 

main/waeup.kofa/trunk/src/waeup/kofa/browser/viewlets.py

@@ -452 +452 @@
     text = _('Manage certificate')
 
+class ShowCourseStudentsActionButton(ManageActionButton):
+    """ 'Show students' button in course.
+    """
+    grok.context(ICourse)
+    grok.view(CoursePage)
+    grok.require('waeup.showStudents')
+    icon = 'actionicon_student.png'
+    text = _('Show students')
+    target = 'showcoursestudents'
+
 class ShowCertificateStudentsActionButton(ManageActionButton):
     """ 'Show students' button for certificates.

main/waeup.kofa/trunk/src/waeup/kofa/students/dynamicroles.py

@@ -29 +29 @@
 from waeup.kofa.students.interfaces import IStudent
 
-# All components in here have the same context: Student instances
-grok.context(IStudent)
-
 class StudentPrincipalRoleManager(AnnotationPrincipalRoleManager,
                                     grok.Adapter):
     grok.provides(IPrincipalRoleManager)
+    grok.context(IStudent)
 
     #: The attribute name to lookup for additional roles
@@ -70 +68 @@
             obj = getattr(self._context, self.extra_attrib, None)
             current_level = 0
-        # Lookup local roles for connected course and all parent
+        # Lookup local roles for connected certificate and all parent
         # objects. This way we fake 'role inheritance'.
         while obj is not None:

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_browser.py

@@ -1406 +1406 @@
         self.assertTrue(self.student_id in self.browser.contents)
 
+    def test_handle_courses_by_lecturer(self):
+        # Create course lecturer
+        self.app['users'].addUser('mrslecturer', 'mrslecturersecret')
+        self.app['users']['mrslecturer'].email = 'mrslecturer@foo.ng'
+        self.app['users']['mrslecturer'].title = u'Mercedes Benz'
+        # Assign local Courselecturer100 role for a certificate
+        course = self.app['faculties']['fac1']['dep1'].courses['COURSE1']
+        prmlocal = IPrincipalRoleManager(course)
+        prmlocal.assignRoleToPrincipal('waeup.local.Lecturer', 'mrslecturer')
+        # Login as lecturer
+        self.browser.open(self.login_path)
+        self.browser.getControl(name="form.login").value = 'mrslecturer'
+        self.browser.getControl(name="form.password").value = 'mrslecturersecret'
+        self.browser.getControl("Login").click()
+        self.assertMatches('...You logged in...', self.browser.contents)
+        # CO can see her roles
+        self.browser.getLink("My Roles").click()
+        self.assertMatches(
+            '...<div>Academics Officer (view only)</div>...',
+            self.browser.contents)
+        # But not her local role ...
+        self.assertFalse('Lecturer' in self.browser.contents)
+        # ... because we forgot to notify the course that the local role
+        # has changed
+        notify(LocalRoleSetEvent(
+            course, 'waeup.local.Lecturer', 'mrslecturer', granted=True))
+        self.browser.open('http://localhost/app/users/mrslecturer/my_roles')
+        self.assertTrue('Lecturer' in self.browser.contents)
+        self.assertMatches(
+            '...<a href="http://localhost/app/faculties/fac1/dep1/courses/COURSE1">...',
+            self.browser.contents)
+        # The lecturer can go to her course
+        self.browser.getLink(
+            "http://localhost/app/faculties/fac1/dep1/courses/COURSE1").click()
+        # and view the list of students
+        self.browser.getLink("Show students").click()
+        self.assertTrue('<th>Fullname</th>' in self.browser.contents)
+        # No student in course so far
+        self.assertFalse(self.student_id in self.browser.contents)
+        studylevel = createObject(u'waeup.StudentStudyLevel')
+        studylevel.level = 100
+        self.student['studycourse'].addStudentStudyLevel(
+            self.certificate, studylevel)
+        # Now the student has registered the course and can
+        # be seen by the lecturer.
+        self.assertFalse(self.student_id in self.browser.contents)
+        # XXX: So far the lecturer can neither access ths student ...
+        self.assertRaises(
+            Unauthorized, self.browser.open, self.student_path)
+        # ... nor the respective course ticket since a
+        # CourseTicketPrincipalRoleManager does not yet exist.
+        self.assertTrue('COURSE1' in self.student['studycourse']['100'].keys())
+        course_ticket_path = self.student_path + '/studycourse/100/COURSE1'
+        self.assertRaises(
+            Unauthorized, self.browser.open, course_ticket_path)
+
     def test_change_current_mode(self):
         self.browser.addHeader('Authorization', 'Basic mgr:mgrpw')