Changeset 9333

Timestamp:

14 Oct 2012, 04:54:11 (12 years ago)

Author:

Henrik Bettermann

Message:

Reorganize course batch processing. Use courses_catalog for getting entry in update mode.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/university

Files:

• batching.py (modified) (3 diffs)
• tests/sample_course_data_update.csv (added)
• tests/test_batching.py (modified) (3 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/university/batching.py

@@ -211 +211 @@
         return
 
-class CourseProcessor(FacultyProcessor):
-    """A batch processor for ICourse objects.
-    """
-    grok.implements(IBatchProcessor)
-    grok.provides(IBatchProcessor)
-    grok.context(Interface)
-    util_name = 'courseprocessor'
-    grok.name(util_name)
-
-    name = u'Course Processor'
-    iface = ICourse
-    allowed_roles = Course.local_roles
-
-    location_fields = ['code', 'faculty_code', 'department_code']
-    factory_name = 'waeup.Course'
-
-    mode = None
-
-    def parentsExist(self, row, site):
-        if not 'faculties' in site.keys():
-            return False
-        if not row['faculty_code'] in site['faculties'].keys():
-            return False
-        faculty = site['faculties'][row['faculty_code']]
-        return row['department_code'] in faculty.keys()
-
-    def entryExists(self, row, site):
-        if not self.parentsExist(row, site):
-            return False
-        parent = self.getParent(row, site)
-        return row['code'] in parent.keys()
-
-    def getParent(self, row, site):
-        dept = site['faculties'][row['faculty_code']][row['department_code']]
-        return dept.courses
-
-    def getEntry(self, row, site):
-        if not self.entryExists(row, site):
-            return None
-        parent = self.getParent(row, site)
-        return parent.get(row['code'])
-
-    def addEntry(self, obj, row, site):
-        parent = self.getParent(row, site)
-        parent.addCourse(obj)
-        return
-
-    def delEntry(self, row, site):
-        parent = self.getParent(row, site)
-        del parent[row['code']]
-        return
-
 class CertificateProcessor(FacultyProcessor):
     """A batch processor for ICertificate objects.
@@ -289 +237 @@
 
     def checkHeaders(self, headerfields, mode='create'):
-        req = self.req[mode]
-        # Check for required fields...
-        for field in req:
-            if not field in headerfields:
-                raise FatalCSVError(
-                    "Need at least columns %s for import!" %
-                    ', '.join(["'%s'" % x for x in req]))
-        # Check for double fields. Cannot happen because this error is
-        # already catched in views
-        not_ignored_fields = [x for x in headerfields
-                              if not x.startswith('--')]
-        if len(set(not_ignored_fields)) < len(not_ignored_fields):
-            raise FatalCSVError(
-                "Double headers: each column name may only appear once.")
+        super(CertificateProcessor, self).checkHeaders(headerfields, mode)
         if mode == 'create':
             if not 'faculty_code' in headerfields \
@@ -359 +294 @@
         return
 
+class CourseProcessor(CertificateProcessor):
+    """A batch processor for ICourse objects.
+    """
+    grok.implements(IBatchProcessor)
+    grok.provides(IBatchProcessor)
+    grok.context(Interface)
+    util_name = 'courseprocessor'
+    grok.name(util_name)
+
+    name = u'Course Processor'
+    iface = ICourse
+    allowed_roles = Course.local_roles
+
+    location_fields = ['code']
+    factory_name = 'waeup.Course'
+
+    mode = None
+
+    def getParent(self, row, site):
+        if not 'faculties' in site.keys():
+            return None
+        # If both faculty and department codes are provided, use
+        # these to get parent.
+        if row.get('faculty_code',None) not in (None, IGNORE_MARKER) and \
+            row.get('department_code',None) not in (None, IGNORE_MARKER):
+            if not row['faculty_code'] in site['faculties'].keys():
+                return None
+            faculty = site['faculties'][row['faculty_code']]
+            if not row['department_code'] in faculty.keys():
+                return None
+            dept = faculty[row['department_code']]
+            return dept.courses
+        # If department code or faculty code is missing,
+        # use catalog to get parent. Makes only sense in update mode but
+        # does also work in create mode.
+        cat = queryUtility(ICatalog, name='courses_catalog')
+        results = list(
+            cat.searchResults(code=(row['code'], row['code'])))
+        if results:
+            return results[0].__parent__
+        return None
+
+    def addEntry(self, obj, row, site):
+        parent = self.getParent(row, site)
+        parent.addCourse(obj)
+        return
+
 class CertificateCourseProcessor(FacultyProcessor):
     """A batch processor for ICertificateCourse objects.

main/waeup.kofa/trunk/src/waeup/kofa/university/tests/test_batching.py

@@ -72 +72 @@
 
 COURSE_HEADER_FIELDS = COURSE_SAMPLE_DATA.split(
+    '\n')[0].split(',')
+
+COURSE_SAMPLE_DATA_UPDATE = open(
+    os.path.join(os.path.dirname(__file__), 'sample_course_data_update.csv'),
+    'rb').read()
+
+COURSE_HEADER_FIELDS_UPDATE = COURSE_SAMPLE_DATA_UPDATE.split(
     '\n')[0].split(',')
 
@@ -441 +448 @@
         self.row4 = dict(department_code='DEP1', faculty_code='FAC1', code="CRS1")
 
-        self.csv_file_course = os.path.join(self.workdir, 'sample_course_data.csv')
+        self.csv_file_course = os.path.join(
+            self.workdir, 'sample_course_data.csv')
         open(self.csv_file_course, 'wb').write(COURSE_SAMPLE_DATA)
+        self.csv_file_course_update = os.path.join(
+            self.workdir, 'sample_course_data_update.csv')
+        open(self.csv_file_course_update, 'wb').write(COURSE_SAMPLE_DATA_UPDATE)
         return
 
@@ -513 +524 @@
         self.assertEqual(user_name, 'anne')
         self.assertEqual(local_role, 'waeup.local.Lecturer')
+        shutil.rmtree(os.path.dirname(fin_file))
+        return
+
+    def test_import_update(self):
+        num, num_warns, fin_file, fail_file = self.proc.doImport(
+            self.csv_file_course, COURSE_HEADER_FIELDS)
+        shutil.rmtree(os.path.dirname(fin_file))
+        num, num_warns, fin_file, fail_file = self.proc.doImport(
+            self.csv_file_course_update, COURSE_HEADER_FIELDS_UPDATE, 'update')
+        self.assertEqual(num_warns,0)
+        self.assertEqual(
+            self.app['faculties']['FAC1']['DEP1'].courses['CRS2'].title,
+            'New Title')
         shutil.rmtree(os.path.dirname(fin_file))
         return