Changeset 8843 for main/waeup.kofa/trunk/src/waeup/kofa/applicants

Timestamp:

27 Jun 2012, 14:01:32 (12 years ago)

Author:

Henrik Bettermann

Message:

Catch error if certificate has been removed between application submission and student creation.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/applicants

Files:

• applicant.py (modified) (5 diffs)
• tests/test_applicantcopier.py (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/applicant.py

@@ -27 +27 @@
 from zope.securitypolicy.interfaces import IPrincipalRoleManager
 from zope.interface import implementedBy
-from zope.schema.interfaces import RequiredMissing
+from zope.schema.interfaces import RequiredMissing, ConstraintNotSatisfied
 from hurry.workflow.interfaces import IWorkflowInfo, IWorkflowState
 from waeup.kofa.app import University
@@ -37 +37 @@
 from waeup.kofa.interfaces import MessageFactory as _
 from waeup.kofa.students.vocabularies import RegNumNotInSource
+from waeup.kofa.students.studycourse import StudentStudyCourse
 from waeup.kofa.utils.helpers import attrs_to_fields
 from waeup.kofa.applicants.interfaces import IApplicant, IApplicantEdit
@@ -119 +120 @@
         if self.course_admitted is None:
             return False, _('No course admitted provided.')
-        # Add student object
+        # Set student attributes
         try:
             for name in self.create_names:
@@ -125 +126 @@
         except RequiredMissing, err:
             return False, _('RequiredMissing: %s' % err)
+        except:
+            return False, _('Error: %s' % err)
+        # Finally prove if the certificate still exists
+        try:
+            StudentStudyCourse().certificate = self.course_admitted
+        except ConstraintNotSatisfied, err:
+            return False, _('ConstraintNotSatisfied: %s' % self.course_admitted.code)
+        # Add student
         site = grok.getSite()
         site['students'].addStudent(student)
-        self.student_id = student.student_id
         IWorkflowInfo(self).fireTransition('create')
         IWorkflowInfo(student).fireTransition('admit')
-
         # Set password
         IUserAccount(student).setPassword(self.application_number)
-
         # Save the certificate and set session attributes
         student['studycourse'].certificate = self.course_admitted
@@ -143 +149 @@
         # Update the catalog
         notify(grok.ObjectModifiedEvent(student))
-
         # Save application slip
         self._createApplicationPDF(student, view=view)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/tests/test_applicantcopier.py

@@ -67 +67 @@
         self.browser.getControl(name="form.course_admitted").value = ['CERT1']
         self.browser.getControl("Save").click()
+        # Maybe the certificate has meanwhile been removed
+        del self.app['faculties']['fac1']['dep1'].certificates['CERT1']
+        (success, msg) = self.applicant.createStudent()
+        self.assertFalse(success)
+        self.assertTrue('ConstraintNotSatisfied: CERT1' in msg)
+        # Ok, lets add the certificate and try again
+        self.app['faculties']['fac1']['dep1'].certificates.addCertificate(
+            self.certificate)
         (success, msg) = self.applicant.createStudent()
         self.assertTrue('created' in msg)