Changeset 8667

Timestamp:

11 Jun 2012, 05:24:10 (12 years ago)

Author:

Henrik Bettermann

Message:

We need to customize the attributes to be copied. Therefore it's easier to define these attributes in a list.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/applicants

Files:

• applicant.py (modified) (2 diffs)
• tests/test_applicantcopier.py (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/applicant.py

@@ -54 +54 @@
     grok.provides(IApplicant)
 
+    create_names = [
+        'firstname', 'lastname',
+        'sex', 'date_of_birth',
+        'email', 'phone'
+        ]
+
     def __init__(self):
         super(Applicant, self).__init__()
@@ -113 +119 @@
         # Add student object
         try:
-            student.firstname = self.firstname
-            student.lastname = self.lastname
-            student.sex = self.sex
-            student.date_of_birth = self.date_of_birth
-            student.email = self.email
-            student.phone = self.phone
+            for name in self.create_names:
+                setattr(student, name, getattr(self, name, None))
         except RequiredMissing, err:
             return False, _('RequiredMissing: %s' % err)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/tests/test_applicantcopier.py

@@ -78 +78 @@
         # Student is in state admitted
         self.assertEqual(student.state, 'admitted')
+        # Attributes properly set?
+        self.assertEqual(student.email, 'xx@yy.zz')
+        self.assertEqual(student.firstname, 'John')
+        self.assertEqual(student.lastname, 'Tester')
         # Check if passport image has been copied
         storage = getUtility(IExtFileStore)