Changeset 8665

Timestamp:

10 Jun 2012, 08:59:49 (12 years ago)

Author:

Henrik Bettermann

Message:

Add expired property to be used in views and viewlets.

If strict_deadline is set, applicants are not allowed to open the edit form when application period has expired.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/applicants

Files:

• browser.py (modified) (4 diffs)
• container.py (modified) (2 diffs)
• tests/test_browser.py (modified) (3 diffs)
• viewlets.py (modified) (1 diff)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/browser.py

@@ -19 +19 @@
 """
 import os
-import pytz
 import sys
 import grok
@@ -914 +913 @@
 
     def update(self):
-        if self.context.locked:
+        if self.context.locked or (
+            self.context.__parent__.expired and
+            self.context.__parent__.strict_deadline):
             self.emit_lock_message()
             return
@@ -963 +964 @@
         if state != PAID:
             self.flash(_('The form cannot be submitted. Wrong state!'))
-            return
-        cond1 = self.context.__parent__.strict_deadline
-        cond2 = self.context.__parent__.enddate
-        cond3 = self.context.__parent__.enddate < datetime.now(pytz.utc)
-        if cond1 and (not cond2 or cond3):
-            self.flash(
-                _('The form cannot be submitted. Application period has expired!'))
             return
         IWorkflowInfo(self.context).fireTransition('submit')
@@ -1023 +1017 @@
 
     def update(self):
-        # Check if application has started ...
-        if not self.context.startdate or (
-            self.context.startdate > datetime.now(pytz.utc)):
-            self.flash(_('Application has not yet started.'))
-            self.redirect(self.url(self.context))
-            return
-        # ... or ended
-        if not self.context.enddate or (
-            self.context.enddate < datetime.now(pytz.utc)):
-            self.flash(_('Application has ended.'))
+        if self.context.expired:
+            self.flash(_('Outside application period.'))
             self.redirect(self.url(self.context))
             return

main/waeup.kofa/trunk/src/waeup/kofa/applicants/container.py

@@ -21 +21 @@
 from random import SystemRandom as r
 import grok
+import pytz
+from datetime import datetime
 from zope.component import getUtility
 from zope.component.factory import Factory
@@ -101 +103 @@
         return getUtility(IApplicantsUtils).getApplicantsStatistics(self)
 
+    @property
+    def expired(self):
+        # Check if application has started ...
+        if not self.startdate or (
+            self.startdate > datetime.now(pytz.utc)):
+            return True
+        # ... or ended
+        if not self.enddate or (
+            self.enddate < datetime.now(pytz.utc)):
+            return True
+        return False
+
+
 ApplicantsContainer = attrs_to_fields(ApplicantsContainer)
 

main/waeup.kofa/trunk/src/waeup/kofa/applicants/tests/test_browser.py

@@ -773 +773 @@
         self.assertTrue('Final Submit' in self.browser.contents)
         self.fill_correct_values() # fill other fields with correct values
+        self.browser.getControl("Save").click()
         self.browser.getControl("Final Submit").click()
         # We forgot to upload a passport picture
@@ -789 +790 @@
             in self.browser.contents)
         self.browser.getControl(name="confirm_passport").value = True
+        # If application period has expired and strict-deadline is set
+        # applicants do notsee edit button and can't open
+        # the edit form.
         self.applicantscontainer.enddate = datetime.now(pytz.utc)
-        self.browser.getControl("Final Submit").click()
-        self.assertTrue(
-            'Application period has expired' in self.browser.contents)
+        self.browser.open(self.view_path)
+        self.assertFalse(
+            'Edit application record' in self.browser.contents)
+        self.browser.open(self.edit_path)
+        self.assertTrue(
+            'form is locked' in self.browser.contents)
         # We can either postpone the enddate ...
         self.applicantscontainer.enddate = datetime.now(
             pytz.utc) + timedelta(days=10)
+        self.browser.open(self.edit_path)
         self.browser.getControl(name="confirm_passport").value = True
         self.browser.getControl("Final Submit").click()
@@ -811 +819 @@
         self.browser.goBack(count=1)
         self.browser.getControl("Save").click()
+        # The form is locked.
         self.assertTrue(
             'The requested form is locked' in self.browser.contents)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/viewlets.py

@@ -157 +157 @@
         """Get a URL to the target...
         """
-        if self.context.locked:
+        if self.context.locked or (
+            self.context.__parent__.expired and
+            self.context.__parent__.strict_deadline):
             return
         return self.view.url(self.view.context, self.target)