Changeset 8617 for main/waeup.kofa/trunk/src/waeup/kofa/applicants

Timestamp:

3 Jun 2012, 13:57:01 (12 years ago)

Author:

uli

Message:

Reduce number of site lookups during imports.

File:

• main/waeup.kofa/trunk/src/waeup/kofa/applicants/batching.py (modified) (2 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/applicants/batching.py

@@ -304 +304 @@
         cert = conv_dict.get('course1', None)
         if cert is not None and (mode in ('create', 'update')):
-            # course1 application category must match container's.  We
-            # could move that check into addApplicant, as it is
-            # expensive.
-            #
-            # XXX: getSite() should be avoided here.
-            parent = self.getParent(row, grok.getSite())
+            # course1 application category must match container's.
+            parent = self.getParent(row, self.site)
             if cert.application_category != parent.application_category:
                 errs.append(('course1', 'wrong application category'))
@@ -336 +332 @@
             return 'Applicant is blocked.'
         return None
+
+    def doImport(self, *args, **kw):
+        # XXX: Not thread-safe.  Parallel applicant imports into
+        # different sites could mean a mess.  Luckily this is not a
+        # typical use-case. On the other hand it spares thousands of
+        # site lookups during large imports.
+        # XXX: Maybe this should go into Importer base.
+        self.site = grok.getSite() # needed by checkConversion()
+        return super(ApplicantProcessor, self).doImport(*args, **kw)