Changeset 8492

Timestamp:

22 May 2012, 23:30:17 (12 years ago)

Author:

uli

Message:

Use DatedRotatingFileHandler? for logging.

Location:

main/waeup.kofa/trunk

Files:

• setup.py (modified) (1 diff)
• src/waeup/kofa/utils/logger.py (modified) (3 diffs)
• src/waeup/kofa/utils/tests/test_logger.py (modified) (2 diffs)

main/waeup.kofa/trunk/setup.py

@@ -36 +36 @@
     'zope.schema >= 3.8.0',
     'zope.sendmail',
+    'ulif.loghandlers',
     ],
 

main/waeup.kofa/trunk/src/waeup/kofa/utils/logger.py

@@ -77 +77 @@
 import logging
 from string import Template
+from ulif.loghandlers import DatedRotatingFileHandler
 from zope import schema
 from zope.component import queryUtility
@@ -84 +85 @@
 from waeup.kofa.utils.helpers import get_current_principal
 
-#: Default logfile size (5 KB)
+#: Default logfile size (5 KB, not relevant for DatedRotatingFileHandlers)
 MAX_BYTES = 5 * 1024 ** 2
 
-#: Default num of backup files (5)
-BACKUP_COUNT = 5
+#: Default num of backup files (-1 = indefinite)
+BACKUP_COUNT = -1
 
 #: Default logging level (`logging.INFO')
@@ -212 +213 @@
 
         # Create a rotating file handler logger.
-        handler = logging.handlers.RotatingFileHandler(
-            filename, maxBytes=MAX_BYTES, backupCount=BACKUP_COUNT)
+        handler = DatedRotatingFileHandler(
+            filename, when='MON', backupCount=BACKUP_COUNT)
         handler.setLevel(LEVEL)
         formatter = logging.Formatter(

main/waeup.kofa/trunk/src/waeup/kofa/utils/tests/test_logger.py

@@ -162 +162 @@
         self.assertEqual(len(result.handlers), 1)
         handler = result.handlers[0]
-        self.assertEqual(handler.maxBytes, MAX_BYTES)
+        #self.assertEqual(handler.maxBytes, MAX_BYTES)
         self.assertEqual(handler.backupCount, BACKUP_COUNT)
         self.assertTrue(result.propagate is False)
@@ -254 +254 @@
         self.assertTrue(isinstance(
                 handler, logging.handlers.RotatingFileHandler))
-        self.assertEqual(handler.maxBytes, MAX_BYTES)
+        #self.assertEqual(handler.maxBytes, MAX_BYTES)
         self.assertEqual(handler.backupCount, BACKUP_COUNT)
         self.assertTrue(handler.baseFilename.endswith('logs/sample.log'))