Changeset 8186

Timestamp:

17 Apr 2012, 00:31:10 (12 years ago)

Author:

uli

Message:

Use new helper functions to compute pytz timezones correctly.

Location:

main/waeup.kofa/trunk/src/waeup/kofa

Files:

• accesscodes/accesscode.py (modified) (2 diffs)
• accesscodes/tests/test_accesscode.py (modified) (2 diffs)
• applicants/browser.py (modified) (2 diffs)
• browser/pdf.py (modified) (2 diffs)
• hostels/hostel.py (modified) (3 diffs)
• hostels/tests.py (modified) (1 diff)
• objecthistory.py (modified) (2 diffs)
• students/utils.py (modified) (2 diffs)
• testing.py (modified) (1 diff)
• tests/test_objecthistory.py (modified) (2 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/accesscodes/accesscode.py

@@ -33 +33 @@
 from zope.component import getUtility
 from waeup.kofa.interfaces import IKofaUtils, IKofaPluggable, IObjectHistory
+from waeup.kofa.utils.helpers import now
 from waeup.kofa.utils.logger import Logger
 from waeup.kofa.accesscodes.interfaces import (
@@ -247 +248 @@
         ac_storage = self._getStoragePath()
         tz = getUtility(IKofaUtils).tzinfo
-        now = datetime.now(tz)
-        timestamp = now.strftime('%Y_%m_%d_%H_%M_%S')
+        dt_now = now(tz)
+        timestamp = dt_now.strftime('%Y_%m_%d_%H_%M_%S')
         csv_path = os.path.join(
             ac_storage, '%s-%s_archive-%s-%s.csv' % (

main/waeup.kofa/trunk/src/waeup/kofa/accesscodes/tests/test_accesscode.py

@@ -233 +233 @@
         # Access codes have a history.
         match = re.match(
-            '^....-..-.. ..:..:.. - initialized by system',
+            '^....-..-.. ..:..:.. ..... .+ - initialized by system',
             self.ac1.history)
         assert match is not None
@@ -301 +301 @@
 "prefix","serial","ac","state","history"
 "FOO","9.99","1","0"
-"FOO","0","FOO-1-11111111","used","<YYYY-MM-DD hh:mm:ss> - ..."
-"FOO","1","FOO-1-22222222","initialized","<YYYY-MM-DD hh:mm:ss> - ..."
-"FOO","2","FOO-1-33333333","disabled","<YYYY-MM-DD hh:mm:ss> - ..."
+"FOO","0","FOO-1-11111111","used","<YYYY-MM-DD hh:mm:ss TZ> - ..."
+"FOO","1","FOO-1-22222222","initialized","<YYYY-MM-DD hh:mm:ss TZ> - ..."
+"FOO","2","FOO-1-33333333","disabled","<YYYY-MM-DD hh:mm:ss TZ> - ..."
 '''[1:]
         contents = open(result_path, 'rb').read()

main/waeup.kofa/trunk/src/waeup/kofa/applicants/browser.py

@@ -51 +51 @@
 from waeup.kofa.permissions import get_users_with_local_roles
 from waeup.kofa.students.interfaces import IStudentsUtils
-from waeup.kofa.utils.helpers import string_from_bytes, file_size
+from waeup.kofa.utils.helpers import string_from_bytes, file_size, now
 from waeup.kofa.widgets.datewidget import (
     FriendlyDateDisplayWidget, FriendlyDateDisplayWidget,
@@ -829 +829 @@
         IWorkflowInfo(self.context).fireTransition('submit')
         tz = getUtility(IKofaUtils).tzinfo
-        self.context.application_date = datetime.now(tz)
+        self.context.application_date = now(tz)
         self.context.locked = True
         self.flash(_('Form has been submitted.'))

main/waeup.kofa/trunk/src/waeup/kofa/browser/pdf.py

@@ -34 +34 @@
 from zope.component import getUtility
 from waeup.kofa.browser.interfaces import IPDFCreator
+from waeup.kofa.utils.helpers import now
 from waeup.kofa.interfaces import IKofaUtils
 from waeup.kofa.interfaces import MessageFactory as _
@@ -331 +332 @@
         if not getattr(doc, 'kofa_nodate', False):
             tz = getUtility(IKofaUtils).tzinfo
-            today = datetime.now(tz).strftime('%d/%m/%Y %H:%M:%S')
+            today = now(tz).strftime('%d/%m/%Y %H:%M:%S %z %Z')
             canvas.drawString(2.2*cm, 0.5 * inch,
                 translate(_(u'Date: ${a}', mapping = {'a': today})))

main/waeup.kofa/trunk/src/waeup/kofa/hostels/hostel.py

@@ -29 +29 @@
 from waeup.kofa.interfaces import IKofaUtils
 from waeup.kofa.interfaces import MessageFactory as _
+from waeup.kofa.utils.helpers import now
 
 class Hostel(grok.Container):
@@ -164 +165 @@
 
             # Comment of Martijn:
-            # If you have a non-Persistent subobject (like a list) and you change it,
-            # you need to manually flag the persistence machinery on the object that
-            # its subobject changed, with _p_changed. This is only necessary if some
-            # of the objects are not sublclasses of Persistent. For common built-in
-            # collections in Python such as list and dictionary there are replacements
-            # (PersistentList, PersistentMapping), and more advanced building blocks
+            # If you have a non-Persistent subobject (like a list) and
+            # you change it, you need to manually flag the persistence
+            # machinery on the object that its subobject changed, with
+            # _p_changed. This is only necessary if some of the
+            # objects are not sublclasses of Persistent. For common
+            # built-in collections in Python such as list and
+            # dictionary there are replacements (PersistentList,
+            # PersistentMapping), and more advanced building blocks
             # for indexes (BTrees), that don't have this issue.
             #hostel._p_changed = True
@@ -207 +210 @@
             bedticket.bed = None
             tz = getUtility(IKofaUtils).tzinfo
-            timestamp = datetime.now(tz).strftime("%Y-%m-%d %H:%M:%S")
-            bedticket.bed_coordinates = u'-- booking cancelled on %s --' % timestamp
+            timestamp = now(tz).strftime("%Y-%m-%d %H:%M:%S %z %Z")
+            bedticket.bed_coordinates = u'-- booking cancelled on %s --' % (
+                timestamp,)
             return old_owner
 

main/waeup.kofa/trunk/src/waeup/kofa/hostels/tests.py

@@ -284 +284 @@
           self.browser.contents)
         self.assertMatches(bedticket.bed_coordinates,
-          u' -- booking cancelled on <YYYY-MM-DD hh:mm:ss> --')
+          u' -- booking cancelled on <YYYY-MM-DD hh:mm:ss TZ> --')
         # If we release a free be, nothing will happen
         ctrl = self.browser.getControl(name='val_id')

main/waeup.kofa/trunk/src/waeup/kofa/objecthistory.py

@@ -23 +23 @@
 from zope.annotation.interfaces import IAnnotations
 from waeup.kofa.interfaces import IObjectHistory, IKofaObject, IKofaUtils
-from waeup.kofa.utils.helpers import get_current_principal
+from waeup.kofa.utils.helpers import get_current_principal, now
 
 from waeup.kofa.interfaces import MessageFactory as _
@@ -61 +61 @@
         msgs = self._getMessages()
         tz = getUtility(IKofaUtils).tzinfo
-        timestamp = datetime.now(tz).strftime("%Y-%m-%d %H:%M:%S")
+        timestamp = now(tz).strftime("%Y-%m-%d %H:%M:%S %z %Z")
         user = get_current_principal()
         if user is None:

main/waeup.kofa/trunk/src/waeup/kofa/students/utils.py

@@ -39 +39 @@
 from waeup.kofa.interfaces import MessageFactory as _
 from waeup.kofa.students.interfaces import IStudentsUtils
+from waeup.kofa.utils.helpers import now
 
 SLIP_STYLE = [
@@ -208 +209 @@
       frame_footer = Frame(1*cm,0,width-(2*cm),1*cm)
       tz = getUtility(IKofaUtils).tzinfo
-      timestamp = datetime.now(tz).strftime("%d/%m/%Y %H:%M:%S")
+      timestamp = now(tz).strftime("%d/%m/%Y %H:%M:%S %z %Z")
       left_text = '<font size=10>%s</font>' % timestamp
       story.append(Paragraph(left_text, style["Normal"]))

main/waeup.kofa/trunk/src/waeup/kofa/testing.py

@@ -295 +295 @@
     (re.compile(r'httperror_seek_wrapper:'), 'HTTPError:' ),
     (re.compile('[\d]{10}'), '<10-DIGITS>'),
+    (re.compile('\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d [\+\-]\d\d\d\d [^ ]+'),
+     '<YYYY-MM-DD hh:mm:ss TZ>'),
     (re.compile('\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d'), '<YYYY-MM-DD hh:mm:ss>'),
     (re.compile('\d\d\d\d-\d\d-\d\d \d\d:\d\d:\d\d'), '<DATETIME>'),

main/waeup.kofa/trunk/src/waeup/kofa/tests/test_objecthistory.py

@@ -80 +80 @@
         hist.addMessage('blah')
         result = ''.join(hist.messages)
-        self.assertMatches('<YYYY-MM-DD hh:mm:ss> - blah by system', result)
+        self.assertMatches('<YYYY-MM-DD hh:mm:ss TZ> - blah by system', result)
 
     def test_add_messages_existing_principal(self):
@@ -89 +89 @@
         hist.addMessage('blah')
         result = ''.join(hist.messages)
-        self.assertMatches('<YYYY-MM-DD hh:mm:ss> - blah by Bob', result)
+        self.assertMatches('<YYYY-MM-DD hh:mm:ss TZ> - blah by Bob', result)
 
     def test_messages(self):