Changeset 8082

Timestamp:

9 Apr 2012, 16:35:24 (12 years ago)

Author:

Henrik Bettermann

Message:

Add tests for changes in previous revision and remove additional bug found with these tests.

Location:

main/waeup.kofa/trunk/src/waeup/kofa/students

Files:

• browser.py (modified) (1 diff)
• tests/test_browser.py (modified) (2 diffs)
• tests/test_catalog.py (modified) (2 diffs)

main/waeup.kofa/trunk/src/waeup/kofa/students/browser.py

@@ -225 +225 @@
                 self.flash(_('Empty search string'))
             return
+        if self.searchtype == 'current_session':
+            try:
+                self.searchterm = int(self.searchterm)
+            except ValueError:
+                self.flash('Only year dates allowed (e.g. 2011).')
+                return
         if not 'entries' in form:
             self.hitlist = search(query=self.searchterm,

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_browser.py

@@ -279 +279 @@
         self.browser.getControl("Search").click()
         self.assertTrue('Anna Tester' in self.browser.contents)
+        # Session fileds require integer values
+        self.browser.open(self.container_path)
+        self.browser.getControl(name="searchtype").value = ['current_session']
+        self.browser.getControl(name="searchterm").value = '2004/2005'
+        self.browser.getControl("Search").click()
+        self.assertTrue('Only year dates allowed' in self.browser.contents)
+        self.browser.open(self.manage_container_path)
+        self.browser.getControl(name="searchtype").value = ['current_session']
+        self.browser.getControl(name="searchterm").value = '2004/2005'
+        self.browser.getControl("Search").click()
+        self.assertTrue('Only year dates allowed' in self.browser.contents)
 
         # We can find a student in a certain study_mode
@@ -338 +349 @@
         self.assertTrue('Anna Tester' in self.browser.contents)
         # The old searchterm will be used again
+        self.browser.getControl("Search").click()
+        self.assertTrue('Anna Tester' in self.browser.contents)
+
+        # The catalog is informed when studycourse objects have been
+        # edited
+        self.browser.open(self.studycourse_path + '/manage')
+        self.browser.getControl(name="form.current_session").value = ['2010']
+        self.browser.getControl(name="form.entry_session").value = ['2010']
+        self.browser.getControl(name="form.entry_mode").value = ['ug_ft']
+        self.browser.getControl("Save").click()
+
+        # We can find the student in the new session
+        self.browser.open(self.manage_container_path)
+        self.browser.getControl(name="searchtype").value = ['current_session']
+        self.browser.getControl(name="searchterm").value = '2010'
         self.browser.getControl("Search").click()
         self.assertTrue('Anna Tester' in self.browser.contents)

main/waeup.kofa/trunk/src/waeup/kofa/students/tests/test_catalog.py

@@ -63 +63 @@
         self.student = self.app['students'][self.student_id]
         self.student['studycourse'].certificate = self.certificate
+        self.student['studycourse'].current_session = 2010
         # Update the students_catalog
         notify(grok.ObjectModifiedEvent(self.student))
@@ -128 +129 @@
         assert results[0] is self.app['students'][self.student_id]
 
+    def test_search_by_session(self):
+        # We can find a student in a certain session
+        cat = queryUtility(ICatalog, name='students_catalog')
+        results = cat.searchResults(current_session=(2010,2010))
+        results = [x for x in results] # Turn results generator into list
+        assert len(results) == 1
+        assert results[0] is self.app['students'][self.student_id]
+
 class CourseTicketCatalogTests(CatalogTestSetup):