Changeset 7683

Timestamp:

23 Feb 2012, 07:43:06 (13 years ago)

Author:

Henrik Bettermann

Message:

Merge the vocabularies module with the interfaces module. I don't see any other way to avoid conflicting imports since we have now IApplicantsUtils defined in interfaces and needed in vocabularies.

Location:

main/waeup.sirp/trunk/src/waeup/sirp/applicants

Files:

• browser.py (modified) (2 diffs)
• interfaces.py (modified) (12 diffs)
• tests/test_interfaces.py (modified) (2 diffs)
• vocabularies.py (deleted)

main/waeup.sirp/trunk/src/waeup/sirp/applicants/browser.py

@@ -29 +29 @@
 from waeup.sirp.applicants.interfaces import (
     IApplicant, IApplicantEdit, IApplicantsRoot,
-    IApplicantsContainer, IApplicantsContainerAdd, application_types_vocab,
-    MAX_UPLOAD_SIZE, IApplicantOnlinePayment,
+    IApplicantsContainer, IApplicantsContainerAdd,
+    MAX_UPLOAD_SIZE, IApplicantOnlinePayment, IApplicantsUtils
     )
 from waeup.sirp.applicants.workflow import INITIALIZED, STARTED, PAID, SUBMITTED
@@ -158 +158 @@
         year = data['year']
         code = u'%s%s' % (data['prefix'], year)
-        prefix = application_types_vocab.getTerm(data['prefix'])
+        appcats_dict = getUtility(IApplicantsUtils).getApplicationTypeDict()
+        prefix = appcats_dict[data['prefix']][0]
         title = u'%s %s/%s' % (prefix.title, year, year + 1)
         if code in self.context.keys():

main/waeup.sirp/trunk/src/waeup/sirp/applicants/interfaces.py

@@ -23 +23 @@
 from zope import schema
 from zope.interface import Interface, Attribute, implements, directlyProvides
-from zope.component import getUtilitiesFor, queryUtility
+from zope.component import getUtilitiesFor, queryUtility, getUtility
 from zope.catalog.interfaces import ICatalog
 from zope.schema.interfaces import (
     ValidationError, ISource, IContextSourceBinder)
 from zc.sourcefactory.basic import BasicSourceFactory
+from zc.sourcefactory.contextual import BasicContextualSourceFactory
 from waeup.sirp.schema import TextLineChoice
 from waeup.sirp.interfaces import (
@@ -35 +36 @@
 from waeup.sirp.students.vocabularies import (
     lgas_vocab, CertificateSource, GenderSource)
-from waeup.sirp.applicants.vocabularies import (
-    application_types_vocab, AppCatCertificateSource)
 from waeup.sirp.payments.interfaces import IOnlinePayment
 
@@ -78 +77 @@
 directlyProvides(contextual_reg_num_source, IContextSourceBinder)
 
+class AppCatCertificateSource(CertificateSource):
+    """An application certificate source delivers all courses which belong to
+    a certain application_category.
+    """
+    def getValues(self, context):
+        # appliction category not available when certificate was deleted.
+        # shouldn't that info be part of applicant info instead?
+        # when we cannot determine the appcat, we will display all courses.
+        appcat = getattr(getattr(context, '__parent__', None),
+                         'application_category', None)
+        catalog = getUtility(ICatalog, name='certificates_catalog')
+        result = catalog.searchResults(
+            application_category=(appcat,appcat))
+        result = sorted(result, key=lambda value: value.code)
+        curr_course = context.course1
+        if curr_course is not None and curr_course not in result:
+            # display also current course even if it is not catalogued
+            # (any more)
+            result = [curr_course,] + result
+        return result
+
+class ApplicationTypeSource(BasicContextualSourceFactory):
+    """An application type source delivers screening types defined in the
+    portal.
+    """
+    def getValues(self, context):
+        self.appcats_dict = getUtility(
+            IApplicantsUtils).getApplicationTypeDict()
+        return sorted(self.appcats_dict.keys())
+
+    def getToken(self, context, value):
+        return value
+
+    def getTitle(self, context, value):
+        return self.appcats_dict[value][0]
+
+# Maybe Uniben still needs this ...
+#class ApplicationPinSource(BasicContextualSourceFactory):
+#    """An application pin source delivers PIN prefixes for application
+#    defined in the portal.
+#    """
+#    def getValues(self, context):
+#        self.apppins_dict = getUtility(
+#            IApplicantsUtils).getApplicationTypeDict()
+#        return sorted(self.appcats_dict.keys())
+#
+#    def getToken(self, context, value):
+#        return value
+#
+#    def getTitle(self, context, value):
+#        return u"%s (%s)" % (
+#            self.apppins_dict[value][1],self.apppins_dict[value][0])
+
 class ApplicantContainerProviderSource(BasicSourceFactory):
     """A source offering all available applicants container types.
@@ -119 +171 @@
     """A collection of methods which are subject to customization.
     """
+    pass
 
 class IApplicantsRoot(ISIRPObject, IContainer):
@@ -151 +204 @@
 
     prefix = schema.Choice(
-        title = u'Application target',
-        required = True,
-        default = None,
-        source = application_types_vocab,
+        title = u'Application Target',
+        required = True,
+        default = None,
+        source = ApplicationTypeSource(),
         readonly = True,
         )
@@ -166 +219 @@
 
     year = schema.Choice(
-        title = u'Year of entrance',
+        title = u'Year of Entrance',
         required = True,
         default = None,
@@ -174 +227 @@
 
     provider = schema.Choice(
-        title = u'Applicants container type',
+        title = u'Applicants Container Type',
         required = True,
         default = None,
@@ -181 +234 @@
         )
 
+    # Maybe Uniben still needs this ...
     #ac_prefix = schema.Choice(
     #    title = u'Activation code prefix',
     #    required = True,
     #    default = None,
-    #    source = application_pins_vocab,
+    #    source = ApplicationPinSource(),
     #    )
 
@@ -203 +257 @@
 
     startdate = schema.Date(
-        title = u'Application start date',
+        title = u'Application Start Date',
         required = False,
         default = None,
@@ -209 +263 @@
 
     enddate = schema.Date(
-        title = u'Application closing date',
+        title = u'Application Closing Date',
         required = False,
         default = None,
@@ -254 +308 @@
     """
     prefix = schema.Choice(
-        title = u'Application target',
-        required = True,
-        default = None,
-        source = application_types_vocab,
+        title = u'Application Target',
+        required = True,
+        default = None,
+        source = ApplicationTypeSource(),
         readonly = False,
         )
 
     year = schema.Choice(
-        title = u'Year of entrance',
+        title = u'Year of Entrance',
         required = True,
         default = None,
@@ -270 +324 @@
 
     provider = schema.Choice(
-        title = u'Applicants container type',
+        title = u'Applicants Container Type',
         required = True,
         default = None,

main/waeup.sirp/trunk/src/waeup/sirp/applicants/tests/test_interfaces.py

@@ -22 +22 @@
 from zc.sourcefactory.browser.source import FactoredTerms
 from zope.publisher.browser import TestRequest
-from waeup.sirp.applicants.vocabularies import application_types_vocab
+from waeup.sirp.applicants.interfaces import ApplicationTypeSource
 from waeup.sirp.students.vocabularies import GenderSource
-
-class ApplicationCategoriesTestCase(unittest.TestCase):
-
-    def setUp(self):
-        self.vocab = application_types_vocab
-        return
-
-    def test_vocabulary_len(self):
-        self.assertEqual(len(self.vocab), 10)
-        return
-
-    def test_vocabulary_items(self):
-        self.assertTrue('pude' in self.vocab)
-        return
-
-    def test_term_attributes(self):
-        # Check that each vocab entry provided value, token, and title.
-        term = self.vocab.getTermByToken('pude')
-        self.assertEqual(term.token, 'pude')
-        self.assertEqual(term.value, 'pude')
-        self.assertEqual(term.title, 'Post UDE Screening')
-        return
 
 class InterfacesTest(unittest.TestCase):
@@ -82 +60 @@
     suite = unittest.TestSuite()
     for testcase in [
-            ApplicationCategoriesTestCase,
             InterfacesTest,
             ]: