Changeset 7273

Timestamp:

4 Dec 2011, 21:08:53 (13 years ago)

Author:

Henrik Bettermann

Message:

Add test for student data migration to be sure that student_ids provided in import files are correctly produced and that the random id generator is thus neutralized.

Location:

main/waeup.sirp/trunk/src/waeup/sirp

Files:

• students/tests/sample_student_data_migration.csv (added)
• students/tests/test_batching.py (modified) (3 diffs)
• utils/batching.py (modified) (1 diff)

main/waeup.sirp/trunk/src/waeup/sirp/students/tests/test_batching.py

@@ -61 +61 @@
 
 STUDYCOURSE_HEADER_FIELDS = STUDYCOURSE_SAMPLE_DATA.split(
+    '\n')[0].split(',')
+
+STUDENT_SAMPLE_DATA_MIGRATION = open(
+    os.path.join(os.path.dirname(__file__), 'sample_student_data_migration.csv'),
+    'rb').read()
+
+STUDENT_HEADER_FIELDS_MIGRATION = STUDENT_SAMPLE_DATA_MIGRATION.split(
     '\n')[0].split(',')
 
@@ -98 +105 @@
         self.csv_file_update2 = os.path.join(
             self.workdir, 'sample_student_data_update2.csv')
+        self.csv_file_migration = os.path.join(
+            self.workdir, 'sample_student_data_migration.csv')
         open(self.csv_file, 'wb').write(STUDENT_SAMPLE_DATA)
         open(self.csv_file_update, 'wb').write(STUDENT_SAMPLE_DATA_UPDATE)
         open(self.csv_file_update2, 'wb').write(STUDENT_SAMPLE_DATA_UPDATE2)
+        open(self.csv_file_migration, 'wb').write(STUDENT_SAMPLE_DATA_MIGRATION)
 
     def tearDown(self):
@@ -180 +190 @@
             self.csv_file_update, STUDENT_HEADER_FIELDS_UPDATE, 'remove')
         self.assertEqual(num_warns,0)
+        shutil.rmtree(os.path.dirname(fin_file))
+
+    def test_import_migration_data(self):
+        num, num_warns, fin_file, fail_file = self.importer.doImport(
+            self.csv_file_migration, STUDENT_HEADER_FIELDS_MIGRATION)
+        self.assertEqual(num_warns,0)
+        assert len(self.app['students'].keys()) == 4
+        self.assertTrue('A123456' in self.app['students'].keys())
         shutil.rmtree(os.path.dirname(fin_file))
 

main/waeup.sirp/trunk/src/waeup/sirp/utils/batching.py

@@ -300 +300 @@
                     continue
                 obj = self.callFactory()
-                self.updateEntry(obj, row, site)
+                # Override all values in row, also
+                # student_ids and applicant_ids which have been
+                # generated in the respective __init__ methods before.
+                self.updateEntry(obj, row, site) 
                 try:
                     self.addEntry(obj, row, site)