Changeset 7260

Timestamp:

4 Dec 2011, 07:56:39 (13 years ago)

Author:

Henrik Bettermann

Message:

Let's generate the applicant_id only when the applicant is added to its container to be compliant with the generic batch processor (importer).

Location:

main/waeup.sirp/trunk/src/waeup/sirp/applicants

Files:

• applicant.py (modified) (4 diffs)
• browser.py (modified) (1 diff)
• container.py (modified) (3 diffs)
• interfaces.py (modified) (1 diff)
• tests/test_applicant.py (modified) (4 diffs)
• tests/test_browser.py (modified) (1 diff)
• tests/test_catalog.py (modified) (1 diff)

main/waeup.sirp/trunk/src/waeup/sirp/applicants/applicant.py

@@ -17 +17 @@
 ##
 import os
-from random import SystemRandom as r
 import grok
 from grok import index
@@ -34 +33 @@
     )
 
-def generate_applicant_id(container=None):
-    if container is not None:
-        aid = u"%s_%d" % (container.code, r().randint(99999,1000000))
-        while aid in container.keys():
-            aid = u"%s_%d" % (container.code, r().randint(99999,1000000))
-        return aid
-    else:
-        # In some tests we don't use containers
-        return u"xxx_1234"
-
 class Applicant(grok.Container):
     grok.implements(IApplicant,IApplicantEdit)
     grok.provides(IApplicant)
 
-    def __init__(self, container=None):
+    def __init__(self):
         super(Applicant, self).__init__()
-        self.applicant_id = generate_applicant_id(container)
         self.password = None
         IWorkflowInfo(self).fireTransition('init')
         self.application_date = None
+        self.applicant_id = None
         return
 
@@ -72 +61 @@
     @property
     def application_number(self):
-        return self.applicant_id.split('_')[1]
+        try:
+            return self.applicant_id.split('_')[1]
+        except AttributeError:
+            return None
 
     @property
@@ -110 +102 @@
 
     def __call__(self, *args, **kw):
-        return Applicant(kw['container'])
+        return Applicant()
 
     def getInterfaces(self):

main/waeup.sirp/trunk/src/waeup/sirp/applicants/browser.py

@@ -424 +424 @@
     @grok.action('Create application record')
     def addApplicant(self, **data):
-        applicant = createObject(u'waeup.Applicant', container = self.context)
+        applicant = createObject(u'waeup.Applicant')
         self.applyData(applicant, **data)
         self.context.addApplicant(applicant)

main/waeup.sirp/trunk/src/waeup/sirp/applicants/container.py

@@ -19 +19 @@
 Containers for university applicants.
 """
+from random import SystemRandom as r
 import grok
 from zope.component.factory import Factory
@@ -27 +28 @@
     )
 from waeup.sirp.utils.helpers import attrs_to_fields
+
+def generate_applicant_id(container=None):
+    if container is not None:
+        aid = u"%s_%d" % (container.code, r().randint(99999,1000000))
+        while aid in container.keys():
+            aid = u"%s_%d" % (container.code, r().randint(99999,1000000))
+        return aid
+    else:
+        # In some tests we don't use containers
+        return u"xxx_1234"
 
 class ApplicantsContainer(grok.Container):
@@ -89 +100 @@
             raise TypeError(
                 'ApplicantsContainers contain only IApplicant instances')
+        applicant_id = generate_applicant_id(container=self)
+        applicant.applicant_id = applicant_id
         self[applicant.application_number] = applicant
         return

main/waeup.sirp/trunk/src/waeup/sirp/applicants/interfaces.py

@@ -257 +257 @@
         title = u'Applicant Id',
         required = False,
-        readonly = True,
+        readonly = False,
         )
 

main/waeup.sirp/trunk/src/waeup/sirp/applicants/tests/test_applicant.py

@@ -123 +123 @@
         # we can get an image filename for applicants not in a container
         appl = Applicant()
+        appl.applicant_id = u'dummy_123456'
         chooser = IFileStoreNameChooser(appl)
         result = chooser.chooseName()
         # the file would be stored in a ``_default`` directory.
         self.assertEqual(
-            result, '__img-applicant___default/xxx_1234.jpg')
+            result, '__img-applicant___default/dummy_123456.jpg')
         return
 
@@ -134 +135 @@
         fake_container.__name__ = 'folder'
         fake_container.code = 'folder'
-        appl = Applicant(container=fake_container)
+        appl = Applicant()
+        appl.applicant_id = u'folder_123456'
         appl.__parent__ = fake_container
         chooser = IFileStoreNameChooser(appl)
@@ -147 +149 @@
         fake_container.__name__ = 'folder'
         fake_container.code = 'folder'
-        appl = Applicant(container=fake_container)
+        appl = Applicant()
+        appl.applicant_id = u'folder_123456'
         appl.__parent__ = fake_container
         chooser = IFileStoreNameChooser(appl)
@@ -193 +196 @@
 
     def test_factory(self):
-        obj = self.factory(container=None)
+        obj = self.factory()
         assert isinstance(obj, Applicant)
 

main/waeup.sirp/trunk/src/waeup/sirp/applicants/tests/test_browser.py

@@ -117 +117 @@
 
         # Add an applicant
-        self.applicant = Applicant(container=applicantscontainer)
-        app['applicants']['app2009'][
-            self.applicant.application_number] = self.applicant
+        self.applicant = Applicant()
+        app['applicants']['app2009'].addApplicant(self.applicant)
         IUserAccount(
             self.app['applicants']['app2009'][

main/waeup.sirp/trunk/src/waeup/sirp/applicants/tests/test_catalog.py

@@ -61 +61 @@
         setSite(self.app)
         self.app['applicants']['mystuff'] = self.container
-        self.applicant = Applicant(container=self.container)
-        self.app['applicants']['mystuff'][
-            self.applicant.application_number] = self.applicant
+        self.applicant = Applicant()
+        self.app['applicants']['mystuff'].addApplicant(self.applicant)
         return