Changeset 7256

Timestamp:

3 Dec 2011, 05:46:52 (13 years ago)

Author:

Henrik Bettermann

Message:

pyflakes

Location:

main/waeup.sirp/trunk/src/waeup/sirp/students

Files:

• accommodation.py (modified) (1 diff)
• batching.py (modified) (4 diffs)
• browser.py (modified) (4 diffs)
• container.py (modified) (1 diff)
• dynamicroles.py (modified) (1 diff)
• interfaces.py (modified) (1 diff)
• payments.py (modified) (2 diffs)
• student.py (modified) (2 diffs)
• studycourse.py (modified) (1 diff)
• studylevel.py (modified) (1 diff)
• tests/test_batching.py (modified) (2 diffs)
• tests/test_container.py (modified) (2 diffs)
• utils.py (modified) (3 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/students/accommodation.py

@@ -21 +21 @@
 from datetime import datetime
 import grok
-from grok import index
 from zope.component.interfaces import IFactory
+from zope.interface import implementedBy
 from waeup.sirp.interfaces import academic_sessions_vocab
 from waeup.sirp.students.interfaces import (

main/waeup.sirp/trunk/src/waeup/sirp/students/batching.py

@@ -26 +26 @@
 import grok
 import csv
-import copy
 from zope.interface import Interface
 from zope.schema import getFields
@@ -34 +33 @@
     IBatchProcessor, FatalCSVError, IObjectConverter)
 from waeup.sirp.students.interfaces import (
-    IStudent, IStudentStudyCourse, IStudentStudyCourseImport,
+    IStudent, IStudentStudyCourseImport,
     IStudentUpdateByRegNo, IStudentUpdateByMatricNo)
 from waeup.sirp.utils.batching import BatchProcessor
@@ -57 +56 @@
     @property
     def available_fields(self):
-        result = []
         return sorted(list(set(
             ['student_id','reg_number','matric_number'] + getFields(
@@ -187 +185 @@
     @property
     def available_fields(self):
-        result = []
         return sorted(list(set(
             ['student_id','reg_number','matric_number'] + getFields(

main/waeup.sirp/trunk/src/waeup/sirp/students/browser.py

@@ -21 +21 @@
 import grok
 from time import time
-from datetime import date, datetime
+from datetime import datetime
 from zope.event import notify
 from zope.catalog.interfaces import ICatalog
@@ -58 +58 @@
 from waeup.sirp.authentication import get_principal_role_manager
 from waeup.sirp.hostels.hostel import NOT_OCCUPIED
-from waeup.sirp.utils.helpers import get_user_account, send_mail
+from waeup.sirp.utils.helpers import send_mail
 
 def write_log_message(view, message):
@@ -67 +67 @@
 # Save function used for save methods in pages
 def msave(view, **data):
-    form = view.request.form
     changed_fields = view.applyData(view.context, **data)
     # Turn list of lists into single list
@@ -1998 +1997 @@
     @grok.action('Register course list')
     def RegisterCourses(self, **data):
-        state = IWorkflowState(self.context.getStudent()).getState()
         IWorkflowInfo(self.context.getStudent()).fireTransition('register_courses')
         self.flash('Course list has been registered.')

main/waeup.sirp/trunk/src/waeup/sirp/students/container.py

@@ -20 +20 @@
 """
 import grok
-import os
 from waeup.sirp.students.interfaces import (
     IStudentsContainer, IStudent)

main/waeup.sirp/trunk/src/waeup/sirp/students/dynamicroles.py

@@ -23 +23 @@
 """
 import grok
-from zope.securitypolicy.interfaces import (
-    IPrincipalRoleManager, IPrincipalPermissionManager,)
-from zope.securitypolicy.principalrole import AnnotationPrincipalRoleManager
+from zope.securitypolicy.interfaces import IPrincipalRoleManager
 from zope.securitypolicy.principalpermission import (
     AnnotationPrincipalPermissionManager,)
-from zope.securitypolicy.settings import Allow, Deny, Unset
+from zope.securitypolicy.principalrole import AnnotationPrincipalRoleManager
 from waeup.sirp.students.interfaces import IStudent
 

main/waeup.sirp/trunk/src/waeup/sirp/students/interfaces.py

@@ -17 +17 @@
 ##
 from datetime import datetime
-from zope.interface import Attribute, invariant, Interface
-from zope.interface.exceptions import Invalid
+from zope.interface import Attribute, Interface
 from zope import schema
 from waeup.sirp.interfaces import (

main/waeup.sirp/trunk/src/waeup/sirp/students/payments.py

@@ -20 +20 @@
 """
 import grok
-from grok import index
 from zope.component.interfaces import IFactory
 from zope.interface import implementedBy
@@ -51 +50 @@
     def __init__(self):
         super(StudentOnlinePayment, self).__init__()
-        p_id = None
         return
 

main/waeup.sirp/trunk/src/waeup/sirp/students/student.py

@@ -21 +21 @@
 import os
 import grok
-from grok import index
 from zope.component.interfaces import IFactory
 from zope.interface import implementedBy
@@ -253 +252 @@
         """Create a browsable file-like object.
         """
-        ext = os.path.splitext(filename)[1].lower()
         # call super method to ensure that any old files with
         # different filename extension are deleted.

main/waeup.sirp/trunk/src/waeup/sirp/students/studycourse.py

@@ -21 +21 @@
 """
 import grok
-from grok import index
 from zope.component.interfaces import IFactory
-from zope.securitypolicy.interfaces import IPrincipalRoleManager
+from zope.interface import implementedBy
 from waeup.sirp.students.interfaces import (
     IStudentStudyCourse, IStudentNavigation, IStudentStudyLevel)

main/waeup.sirp/trunk/src/waeup/sirp/students/studylevel.py

@@ -21 +21 @@
 """
 import grok
-from grok import index
-from zope.component.interfaces import IFactory
 from waeup.sirp.students.interfaces import (
     IStudentStudyLevel, IStudentNavigation, ICourseTicket)

main/waeup.sirp/trunk/src/waeup/sirp/students/tests/test_batching.py

@@ -32 +32 @@
     StudentProcessor, StudentStudyCourseProcessor)
 from waeup.sirp.students.student import Student
-from waeup.sirp.students.studycourse import StudentStudyCourse
 from waeup.sirp.testing import FunctionalLayer, FunctionalTestCase
 from waeup.sirp.interfaces import IBatchProcessor
@@ -151 +150 @@
 
     def test_delEntry(self):
-        self.importer.delEntry(
-            dict(student_id=self.student.student_id), self.app)
-        assert self.student.student_id not in self.app['students'].keys()
-
-    def test_delEntry(self):
         assert self.student.student_id in self.app['students'].keys()
         self.importer.delEntry(

main/waeup.sirp/trunk/src/waeup/sirp/students/tests/test_container.py

@@ -19 +19 @@
 Tests for students containers.
 """
-import unittest
 import tempfile
 import shutil
 from zope.interface.verify import verifyClass, verifyObject
-from zope.component.interfaces import IFactory
 from zope.component.hooks import setSite, clearSite
 from waeup.sirp.app import University
@@ -34 +32 @@
     )
 from waeup.sirp.testing import (
-    FunctionalLayer, FunctionalTestCase, get_all_loggers, remove_new_loggers,
-    remove_logger)
+    FunctionalLayer, FunctionalTestCase, remove_logger)
 
 class StudentsContainerTestCase(FunctionalTestCase):

main/waeup.sirp/trunk/src/waeup/sirp/students/utils.py

@@ -20 +20 @@
 import grok
 from random import SystemRandom as r
-from datetime import date, datetime
+from datetime import datetime
 from reportlab.pdfgen import canvas
 from reportlab.lib.units import cm
@@ -29 +29 @@
 from reportlab.platypus.tables import TableStyle
 from zope.formlib.form import setUpEditWidgets
-from waeup.sirp.interfaces import academic_sessions_vocab
 from waeup.sirp.students.interfaces import IStudentsUtils
 
@@ -112 +111 @@
         d['booking_session'] = site_confoguration.accommodation_session
         d['allowed_states'] = site_confoguration.accommodation_states
-        session = str(d['booking_session'])
         # Determine bed type
         studycourse = student['studycourse']