Changeset 7243

Timestamp:

1 Dec 2011, 10:11:59 (13 years ago)

Author:

Henrik Bettermann

Message:

Use only one primarynavtab.pt pagetemplate and render list item only if link_target is provided.

Provide link_target of EnquiriesTab? and ApplicantsAnonTab? only if principal id is zope.anybody.

Location:

main/waeup.sirp/trunk/src/waeup/sirp

Files:

• applicants/browser.py (modified) (3 diffs)
• applicants/browser_templates/primarynavtab.pt (deleted)
• browser/layout.py (modified) (1 diff)
• browser/templates/primarynavtab.pt (modified) (1 diff)
• browser/viewlets.py (modified) (5 diffs)
• hostels/browser.py (modified) (3 diffs)
• hostels/browser_templates/primarynavtab.pt (deleted)
• students/browser_templates/primarynavtab.pt (deleted)
• students/viewlets.py (modified) (3 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/applicants/browser.py

@@ -234 +234 @@
     grok.order(3)
     grok.require('waeup.viewApplicationsTab')
-    grok.template('primarynavtab')
     pnav = 3
     tab_title = u'Applicants'
@@ -252 +251 @@
 
     # Also zope.manager has role Anonymous.
-    # To avoid displaying this tab, uncomment the following.
-    #def tab_title(self):
-    #    userid = self.request.principal.id
-    #    if userid != 'zope.anybody':
-    #        tt = u''
-    #    else:
-    #        tt = u'Application'
-    #    return tt
+    # To avoid displaying this tab, we have to check the principal id too.
+    @property
+    def link_target(self):
+        if self.request.principal.id == 'zope.anybody':
+            return self.view.application_url('applicants')
+        return
 
 class MyApplicationDataTab(PrimaryStudentNavTab):
@@ -266 +263 @@
     grok.order(3)
     grok.require('waeup.viewMyApplicationDataTab')
-    grok.template('primarynavtab')
     pnav = 3
     tab_title = u'My Data'

main/waeup.sirp/trunk/src/waeup/sirp/browser/layout.py

@@ -44 +44 @@
 default_waeup_edit_template.__grok_name__ = 'default_waeup_edit_form'
 
+default_primary_nav_template = grokcore.view.PageTemplateFile(
+    os.path.join('templates', 'primarynavtab.pt'))
+default_primary_nav_template.__grok_name__ = 'default_primary_nav'
+
 
 def NullValidator(*args, **kw):

main/waeup.sirp/trunk/src/waeup/sirp/browser/templates/primarynavtab.pt

@@ -1 @@
-<li tal:attributes="class viewlet/active">
+<li tal:attributes="class viewlet/active" tal:condition="viewlet/link_target">
   <a href="#"
      tal:attributes="href viewlet/link_target"

main/waeup.sirp/trunk/src/waeup/sirp/browser/viewlets.py

@@ -30 +30 @@
 from waeup.sirp.interfaces import (IWAeUPObject, IWAeUPXMLExporter,
                                    IWAeUPXMLImporter, IDataCenter, IUserAccount)
-from waeup.sirp.browser.layout import WAeUPPage
+from waeup.sirp.browser.layout import WAeUPPage, default_primary_nav_template
 from waeup.sirp.utils.helpers import get_user_account
 
@@ -571 +571 @@
     grok.order(1)
     grok.require('waeup.Public')
+    template = default_primary_nav_template
 
     pnav = 0 # This is a kind of id of a tab. If some page provides
@@ -600 +601 @@
     grok.order(1)
     grok.require('waeup.Public')
-    grok.template('primarynavtab')
 
     pnav = 0
@@ -610 +610 @@
     grok.order(2)
     grok.require('waeup.viewAcademics')
-    grok.template('primarynavtab')
 
     pnav = 1
@@ -628 +627 @@
     grok.order(6)
     grok.require('waeup.Anonymous')
-    grok.template('primarynavtab')
     tab_title = u'Enquiries'
     pnav = 2
 
+    # Also zope.manager has role Anonymous.
+    # To avoid displaying this tab, we have to check the principal id too.
     @property
     def link_target(self):
-        return self.view.application_url('enquiries')
+        if self.request.principal.id == 'zope.anybody':
+            return self.view.application_url('enquiries')
+        return
 
 #

main/waeup.sirp/trunk/src/waeup/sirp/hostels/browser.py

@@ -28 +28 @@
 from waeup.sirp.browser.breadcrumbs import Breadcrumb
 from waeup.sirp.browser.resources import datepicker, datatable, tabs, toggleall
+from waeup.sirp.browser.layout import default_primary_nav_template
+from waeup.sirp.browser.pages import delSubobjects
 from waeup.sirp.browser.viewlets import (
     ManageActionButton, PrimaryNavTab, AddActionButton)
@@ -34 +36 @@
     FriendlyDateWidget, FriendlyDateDisplayWidget,
     FriendlyDatetimeDisplayWidget)
-from waeup.sirp.browser.pages import delSubobjects
 from waeup.sirp.authentication import get_principal_role_manager
 from waeup.sirp.hostels.container import HostelsContainer
@@ -68 +69 @@
     grok.order(5)
     grok.require('waeup.viewHostels')
-    grok.template('primarynavtab')
-
+    template = default_primary_nav_template
     pnav = 5
     tab_title = u'Hostels'

main/waeup.sirp/trunk/src/waeup/sirp/students/viewlets.py

@@ -25 +25 @@
 from waeup.sirp.browser import DEFAULT_IMAGE_PATH
 from waeup.sirp.browser.viewlets import PrimaryNavTab
+from waeup.sirp.browser.layout import default_primary_nav_template
 from waeup.sirp.students.browser import (
     StudentClearanceDisplayFormPage, StudentClearanceManageFormPage,
@@ -164 +165 @@
     grok.order(4)
     grok.require('waeup.viewStudentsTab')
-    grok.template('primarynavtab')
 
     pnav = 4
@@ -183 +183 @@
     grok.baseclass()
     grok.viewletmanager(PrimaryStudentNavManager)
-    grok.template('primarynavtab')
+    template = default_primary_nav_template
     grok.order(1)
     grok.require('waeup.Authenticated')