Changeset 7203

Timestamp:

25 Nov 2011, 20:54:14 (13 years ago)

Author:

Henrik Bettermann

Message:

Add indexes faccode, depcode and certcode to students_catalog.

Location:

main/waeup.sirp/trunk/src/waeup/sirp/students

Files:

• catalog.py (modified) (1 diff)
• interfaces.py (modified) (1 diff)
• student.py (modified) (1 diff)
• tests/test_browser.py (modified) (2 diffs)
• tests/test_catalog.py (modified) (4 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/students/catalog.py

@@ -39 +39 @@
     matric_number = index.Field(attribute='matric_number')
     state = index.Field(attribute='state')
-    certificate = index.Field(attribute='certificate')
+    certcode = index.Field(attribute='certcode')
+    depcode = index.Field(attribute='depcode')
+    faccode = index.Field(attribute='faccode')
     current_session = index.Field(attribute='current_session')
 

main/waeup.sirp/trunk/src/waeup/sirp/students/interfaces.py

@@ -123 +123 @@
     state = Attribute('Returns the registration state of a student')
     password = Attribute('Encrypted password of a student')
-    certificate = Attribute('The certificate of any chosen study course')
+    certcode = Attribute('The certificate code of any chosen study course')
+    depcode = Attribute('The department code of any chosen study course')
+    faccode = Attribute('The faculty code of any chosen study course')
     current_session = Attribute('The current session of the student')
 

main/waeup.sirp/trunk/src/waeup/sirp/students/student.py

@@ -76 +76 @@
 
     @property
-    def certificate(self):
+    def certcode(self):
         cert = getattr(self.get('studycourse', None), 'certificate', None)
-        return cert
+        if cert is not None:
+            return cert.code
+        return
+
+    @property
+    def faccode(self):
+        cert = getattr(self.get('studycourse', None), 'certificate', None)
+        if cert is not None:
+            return cert.__parent__.__parent__.__parent__.code
+        return
+
+    @property
+    def depcode(self):
+        cert = getattr(self.get('studycourse', None), 'certificate', None)
+        if cert is not None:
+            return cert.__parent__.__parent__.code
+        return
 
     @property

main/waeup.sirp/trunk/src/waeup/sirp/students/tests/test_browser.py

@@ -257 +257 @@
                            self.browser.contents)
 
+        # We can find a student with a certain student_id
         self.browser.open(self.container_path)
         self.browser.getControl("Search").click()
@@ -265 +266 @@
         self.assertTrue('Anna Tester' in self.browser.contents)
 
+        # We can find a student with a certain fullname
         self.browser.open(self.manage_container_path)
         self.browser.getControl("Search").click()

main/waeup.sirp/trunk/src/waeup/sirp/students/tests/test_catalog.py

@@ -16 +16 @@
 ## Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 ##
+import grok
 import shutil
 import tempfile
+from zope.event import notify
 from zope.catalog.interfaces import ICatalog
-from zope.component import queryUtility
+from zope.component import queryUtility, createObject
 from zope.component.hooks import setSite
 from waeup.sirp.app import University
 from waeup.sirp.testing import FunctionalLayer, FunctionalTestCase
 from waeup.sirp.students.student import Student
+from waeup.sirp.university.faculty import Faculty
+from waeup.sirp.university.department import Department
 
 class CatalogTestSetup(FunctionalTestCase):
@@ -43 +47 @@
         self.app = self.getRootFolder()['app']
         setSite(self.app)
+        self.certificate = createObject('waeup.Certificate')
+        self.certificate.code = u'CERT1'
+        self.app['faculties']['fac1'] = Faculty(code=u'fac1')
+        self.app['faculties']['fac1']['dep1'] = Department(code=u'dep1')
+        self.app['faculties']['fac1']['dep1'].certificates.addCertificate(
+            self.certificate)
 
-        # Create students
+        # Create student with studycourse subobject
         student = Student()
         student.fullname = u'Bob Tester'
-        student.student_id = u'A123456'
-        self.app['students'][student.student_id] = student
+        self.app['students'].addStudent(student)
+        self.student_id = student.student_id
+        self.student = self.app['students'][self.student_id]
+        self.student['studycourse'].certificate = self.certificate
+        # Update the catalog
+        notify(grok.ObjectModifiedEvent(self.student))
         return
 
@@ -68 +82 @@
         # We can find a certain student id
         cat = queryUtility(ICatalog, name='students_catalog')
-        results = cat.searchResults(student_id=('A123456', 'A123456'))
+        results = cat.searchResults(student_id=(self.student_id, self.student_id))
         results = [x for x in results] # Turn results generator into list
         assert len(results) == 1
-        assert results[0] is self.app['students']['A123456']
+        assert results[0] is self.app['students'][self.student_id]
 
     def test_search_by_name(self):
@@ -79 +93 @@
         results = [x for x in results] # Turn results generator into list
         assert len(results) == 1
-        assert results[0] is self.app['students']['A123456']
+        assert results[0] is self.app['students'][self.student_id]
+
+    def test_search_by_department(self):
+        # We can find a student studying in a certain department
+        cat = queryUtility(ICatalog, name='students_catalog')
+        results = cat.searchResults(depcode=('dep1','dep1'))
+        results = [x for x in results] # Turn results generator into list
+        assert len(results) == 1
+        assert results[0] is self.app['students'][self.student_id]
+
+    def test_search_by_faculty(self):
+        # We can find a student studying in a certain faculty
+        cat = queryUtility(ICatalog, name='students_catalog')
+        results = cat.searchResults(faccode=('fac1','fac1'))
+        results = [x for x in results] # Turn results generator into list
+        assert len(results) == 1
+        assert results[0] is self.app['students'][self.student_id]