Changeset 7201

Timestamp:

25 Nov 2011, 14:25:43 (13 years ago)

Author:

Henrik Bettermann

Message:

Restrict view access for clearance officers only to students which can be cleared by the officer. No further site role is required (see comment in browser_test)

Location:

main/waeup.sirp/trunk/src/waeup/sirp/students

Files:

• permissions.py (modified) (1 diff)
• tests/test_browser.py (modified) (2 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/students/permissions.py

@@ -75 +75 @@
     grok.name('waeup.StudentsClearanceOfficer')
     grok.title(u'Clearance Officer (all students)')
-    grok.permissions('waeup.clearStudent')
+    grok.permissions('waeup.clearStudent','waeup.viewStudent')

main/waeup.sirp/trunk/src/waeup/sirp/students/tests/test_browser.py

@@ -659 +659 @@
         # Create clearance officer
         self.app['users'].addUser('mrclear', 'mrclearsecret')
-        # Clearance officers need to get the StudentsOfficer site role
-        prmglobal = IPrincipalRoleManager(self.app)
-        prmglobal.assignRoleToPrincipal('waeup.StudentsOfficer', 'mrclear')
+        # Clearance officers need not necessarily to get
+        # the StudentsOfficer site role
+        #prmglobal = IPrincipalRoleManager(self.app)
+        #prmglobal.assignRoleToPrincipal('waeup.StudentsOfficer', 'mrclear')
         # Assign local ClearanceOfficer role
         department = self.app['faculties']['fac1']['dep1']
@@ -679 +680 @@
             '...<div>Academics Officer (view only)</div>...',
             self.browser.contents)
-        self.assertMatches(
-            '...<div>Students Officer (view only)</div>...',
-            self.browser.contents)
+        #self.assertMatches(
+        #    '...<div>Students Officer (view only)</div>...',
+        #    self.browser.contents)
         # But not his local role ...
         self.assertFalse('Clearance Officer' in self.browser.contents)