Changeset 7188

Timestamp:

25 Nov 2011, 06:54:08 (13 years ago)

Author:

Henrik Bettermann

Message:

Add test for MyRolesPage? in w.s.b.pages. Even if this page is defined in another package, it's a good place to test it.

permissions.py: Fix typo

Location:

main/waeup.sirp/trunk/src/waeup/sirp

Files:

• permissions.py (modified) (1 diff)
• students/tests/test_browser.py (modified) (5 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/permissions.py

@@ -77 +77 @@
 class AcademicsOfficer(grok.Role):
     grok.name('waeup.AcademicsOfficer')
-    grok.title(u'Academics Offiver (view only)')
+    grok.title(u'Academics Officer (view only)')
     grok.permissions('waeup.viewAcademics')
 

main/waeup.sirp/trunk/src/waeup/sirp/students/tests/test_browser.py

@@ -1 @@
-##
-## test_browser.py
-## Login : <uli@pu.smp.net>
-## Started on  Tue Mar 29 11:31:11 2011 Uli Fouquet
 ## $Id$
 ## 
@@ -42 +38 @@
 from waeup.sirp.university.department import Department
 from waeup.sirp.interfaces import IUserAccount
+from waeup.sirp.authentication import LocalRoleSetEvent
 from waeup.sirp.hostels.hostel import Hostel, Bed, NOT_OCCUPIED
 
@@ -647 +644 @@
         # Create clearance officer
         self.app['users'].addUser('mrclear', 'mrclearsecret')
+        # Clearance officers need to get the StudentsOfficer site role
         prmglobal = IPrincipalRoleManager(self.app)
         prmglobal.assignRoleToPrincipal('waeup.StudentsOfficer', 'mrclear')
-        prmlocal = IPrincipalRoleManager(self.app['faculties']['fac1']['dep1'])
+        # Assign local ClearanceOfficer role
+        department = self.app['faculties']['fac1']['dep1']
+        prmlocal = IPrincipalRoleManager(department)
         prmlocal.assignRoleToPrincipal('waeup.local.ClearanceOfficer', 'mrclear')
         IWorkflowInfo(self.student).fireTransition('admit')
@@ -659 +659 @@
         self.browser.getControl("Login").click()
         self.assertTrue('You logged in' in self.browser.contents)
+        # CO can see his roles
+        self.browser.getLink("My Roles").click()
+        self.assertMatches(
+            '...<div>Academics Officer (view only)</div>...',
+            self.browser.contents)
+        self.assertMatches(
+            '...<div>Students Officer (view only)</div>...',
+            self.browser.contents)
+        # But not his local role ...
+        self.assertFalse('Clearance Officer' in self.browser.contents)
+        # ... because we forgot to notify the department that the local role
+        # has changed
+        notify(LocalRoleSetEvent(
+            department, 'waeup.local.ClearanceOfficer', 'mrclear', granted=True))
+        self.browser.open('http://localhost/app/users/mrclear/my_roles')
+        self.assertTrue('Clearance Officer' in self.browser.contents)
+        self.assertMatches(
+            '...<a href="http://localhost/app/faculties/fac1/dep1">...',
+            self.browser.contents)
+        # CO can view the student
         self.browser.open(self.clearance_student_path)
         self.assertEqual(self.browser.headers['Status'], '200 Ok')
         self.assertEqual(self.browser.url, self.clearance_student_path)
-        # Only in state clearance requested the co does see the 'Clear' button
+        # Only in state clearance requested the CO does see the 'Clear' button
         self.assertFalse('Clear student' in self.browser.contents)
         IWorkflowInfo(self.student).fireTransition('request_clearance')
@@ -681 +701 @@
         self.assertTrue('State: <span>clearance started</span>'
             in self.browser.contents)
-        # The clearance officer can't clear students if not in state
+        # The CO can't clear students if not in state
         # clearance requested
         self.browser.open(self.student_path + '/clear')