Changeset 7124

Timestamp:

17 Nov 2011, 11:01:25 (13 years ago)

Author:

Henrik Bettermann

Message:

Use a constraint for password validation.

It seems that the constraint does not comply with the PasswordChangeCredentialsPlugin?. The test fails because the new credentials have been set although the form validation failed.

What shall we do?

Location:

main/waeup.sirp/trunk/src/waeup/sirp/students

Files:

• interfaces.py (modified) (2 diffs)
• tests/test_browser.py (modified) (1 diff)

main/waeup.sirp/trunk/src/waeup/sirp/students/interfaces.py

@@ -66 +66 @@
     """
 
+    def validPassword(value):
+        return len(value) > 3
+
     password = schema.Password(
         title = u'New password',
         required = False,
+        constraint = validPassword,
         )
 
@@ -74 +78 @@
         title = u'Retype new password',
         required = False,
+        constraint = validPassword,
         )
 

main/waeup.sirp/trunk/src/waeup/sirp/students/tests/test_browser.py

@@ -650 +650 @@
         # Change password
         self.browser.getLink("Change password").click()
+        self.browser.getControl(name="form.password").value = 'pw'
+        self.browser.getControl(
+            name="form.password_repeat").value = 'pw'
+        self.browser.getControl("Save").click()
+        self.assertTrue('Constraint not satisfied' in self.browser.contents)
         self.browser.getControl(name="form.password").value = 'new_password'
         self.browser.getControl(