Changeset 7103 for main/waeup.sirp/trunk/src/waeup/sirp/students

Timestamp:

13 Nov 2011, 10:22:25 (13 years ago)

Author:

Henrik Bettermann

Message:

File name choosers generally don't know the extension of the file stored. So we have to feed the chooseName method with the extension (ext) of the file stored in the file system.

This may conflict somehow with the idea behind the file name chooser. I think you (Uli) intended to use only the attr parameter to select a proper extension. In my opinion it's better to use attr and ext.

Location:

main/waeup.sirp/trunk/src/waeup/sirp/students

Files:

• student.py (modified) (2 diffs)
• viewlets.py (modified) (3 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/students/student.py

@@ -177 +177 @@
         return name == self.chooseName()
 
-    def chooseName(self, name=None, attr=None):
+    def chooseName(self, name=None, attr=None, ext=u''):
         """Get a valid file id for student context.
 
@@ -195 +195 @@
 
         """
-        ext = u''
         if name and name.count('.') == 1:
             basename, ext = os.path.splitext(name)
-        ext.lower()
+            ext.lower()
         stud_id = self.context.student_id
         marked_filename = '__%s__%s/%s/%s_%s%s' % (

main/waeup.sirp/trunk/src/waeup/sirp/students/viewlets.py

@@ -288 +288 @@
     grok.baseclass()
     attr = None
+    ext = u'.jpg'
 
     def render(self):
@@ -293 +294 @@
         # for file storage.
         image = getUtility(IExtFileStore).getFileByContext(
-            self.context, attr=self.attr)
+            self.context, attr=self.attr, ext=self.ext)
         self.response.setHeader(
             'Content-Type', 'image/jpeg')
@@ -306 +307 @@
     grok.name('birth_certificate.jpg')
     attr = u'birth_certificate'
+    ext = u'.jpg'