Changeset 710 for WAeUP_SRP/trunk

Timestamp:

16 Oct 2006, 22:30:16 (18 years ago)

Author:

joachim

Message:

fixed several bugs in the Apply for PUME Process:
jamb_reg_no had wrong widget
applying with a different PIN a second time led to an error.

the new fields:
appl_email, appl_mobile are set to hidden in laymode create
could not set the fields to required, cause that broke the applyForm.
layout: student_application.xml still has them set to required.

Location:

WAeUP_SRP/trunk

Files:

• Students.py (modified) (1 diff)
• WAeUPTables.py (modified) (1 diff)
• Widgets.py (modified) (4 diffs)
• profiles/default/layouts/student_application.xml (modified) (2 diffs)
• profiles/default/layouts/student_application_fe.xml (modified) (3 diffs)
• skins/waeup_pins/getBatchInfo.py (modified) (1 diff)
• skins/waeup_student/layout_application_edit.pt (modified) (1 diff)
• skins/waeup_student/passport_entry_view.pt (modified) (2 diffs)
• skins/waeup_student/student_edit.py (modified) (1 diff)

WAeUP_SRP/trunk/Students.py

@@ -28 +28 @@
     if letter not in ('ABCDEFGIHKLMNOPQRSTUVWXY'):
         letter= r.choice('ABCDEFGHKLMNPQRSTUVWXY')
-    return "%c%d" % (letter,r.randint(99999,1000000))
+    students = context.portal_catalog(meta_type = "StudentsFolder")[-1]
+    sid = "%c%d" % (letter,r.randint(99999,1000000))
+    while hasattr(students, sid):
+        sid = "%c%d" % (letter,r.randint(99999,1000000))
+    return sid 
     #return "%c%d" % (r.choice('ABCDEFGHKLMNPQRSTUVWXY'),r.randint(99999,1000000))
 

WAeUP_SRP/trunk/WAeUPTables.py

@@ -104 +104 @@
 
 
-    def searchAndSetRecord(self, uid, student_id):
+    def searchAndSetRecord(self, uid, student_id,prefix):
         #records = self.searchResults(uid=uid)
+        records = self.searchResults(student = student_id)
+        if len(records) > 0:
+            for r in records:
+                if r.pin != uid and r.prefix_batch.startswith(prefix): 
+                    return -2
         records = self.searchResults({"%s" % self.key : uid})
         if len(records) > 1:

WAeUP_SRP/trunk/Widgets.py

@@ -214 +214 @@
 ###)
 
-class StudentIdWidget(CPSStringWidget): ###(
-    """ StudentId Widget"""
-    meta_type = "StudentId Widget"
-    digits = 8
-    digits_str = "N"*digits
-    letters = 2
-    letters_str = "L"*letters
-
-    def validate(self, datastructure, **kw):
-        """Validate datastructure and update datamodel."""
-
-        valid = CPSStringWidget.validate(self, datastructure, **kw)
-        if not valid:
-            return 0
-        else:
-            widget_id = self.getWidgetId()
-            value = datastructure[widget_id]
-            err = 0
-            if not (len(value) == self.digits + self.letters and value[:self.digits].isdigit() and value[self.digits:].isalpha()):
-                err = 'Invalid Registration Number in the format: %s%s with N = Number, L = Letter' % (self.digits_str,self.letters_str)
-            if err:
-                datastructure.setError(widget_id, err)
-            else:
-                datamodel = datastructure.getDataModel()
-                datamodel[self.fields[0]] = value
-
-            return not err
-
-InitializeClass(StudentIdWidget)
-widgetRegistry.register(StudentIdWidget)
-
-###)
+##class StudentIdWidget(CPSStringWidget): ###(
+##    """ StudentId Widget"""
+##    meta_type = "StudentId Widget"
+##    digits = 8
+##    digits_str = "N"*digits
+##    letters = 2
+##    letters_str = "L"*letters
+##
+##    def validate(self, datastructure, **kw):
+##        """Validate datastructure and update datamodel."""
+##
+##        valid = CPSStringWidget.validate(self, datastructure, **kw)
+##        if not valid:
+##            return 0
+##        else:
+##            widget_id = self.getWidgetId()
+##            value = datastructure[widget_id]
+##            err = 0
+##            if not (len(value) == self.digits + self.letters and value[:self.digits].isdigit() and value[self.digits:].isalpha()):
+##                err = 'Invalid Registration Number in the format: %s%s with N = Number, L = Letter' % (self.digits_str,self.letters_str)
+##            if err:
+##                datastructure.setError(widget_id, err)
+##            else:
+##                datamodel = datastructure.getDataModel()
+##                datamodel[self.fields[0]] = value
+##
+##            return not err
+##
+##InitializeClass(StudentIdWidget)
+##widgetRegistry.register(StudentIdWidget)
+##
+#####)
 
 class JambRegNoWidget(CPSStringWidget): ###(
@@ -270 +270 @@
                 s = getStudentByRegNo(self,value)
                 if s is None:
-                    err = 'No JAMB data for %s' % (value)
+                    err = 'No Student with JAMB-Reg-No %s' % (value)
             if err:
                 datastructure.setError(widget_id, err)
@@ -342 +342 @@
             ref = datastructure[self.reference]
         #import pdb;pdb.set_trace()
-        ok = pins.searchAndSetRecord(pin,ref)
+        ok = pins.searchAndSetRecord(pin,ref,self.prefix)
         while 1:
-            if ok == -1:
+            if ok == -2:
+                err = 'You have already applied with a different Pin, please login'
+                break
+            elif ok == -1:
                 err = 'invalid Pin'
                 break
@@ -351 +354 @@
                 break
             if ok >= 1:
+                #import pdb;pdb.set_trace()
                 if self.isStudent():
                     student = self.getStudentInfo()['student']

WAeUP_SRP/trunk/profiles/default/layouts/student_application.xml

@@ -50 +50 @@
  </widget>
  <widget name="appl_email" meta_type="Email Widget">
+  <property name="is_required">True</property>
   <property name="title">Email Address</property>
   <property name="fields">
@@ -158 +159 @@
   <property name="hidden_readonly_layout_modes"/>
  </widget>
- <widget name="jamb_reg_no" meta_type="StudentId Widget">
+ <widget name="jamb_reg_no" meta_type="JambRegNo Widget">
   <property name="title">JAMB Registration Number</property>
   <property name="fields">

WAeUP_SRP/trunk/profiles/default/layouts/student_application_fe.xml

@@ -61 +61 @@
   <property name="label">Email Address</property>
   <property name="label_edit">Email Address</property>
-  <property name="readonly_layout_modes">
-  </property>
-  <property name="hidden_layout_modes">
-  </property>
+  <property name="is_required">False</property>
+  <property name="readonly_layout_modes">
+  </property>
+  <property name="hidden_layout_modes">create</property>
   <property name="hidden_readonly_layout_modes"/>
  </widget>
@@ -73 +73 @@
   </property>
   <property name="label">Mobile Phone No</property>
+  <property name="is_required">False</property>
   <property name="label_edit">Mobile Phone No</property>
   <property name="readonly_layout_modes">
   </property>
-  <property name="hidden_layout_modes">
-  </property>
+  <property name="hidden_layout_modes">create</property>
   <property name="hidden_readonly_layout_modes"/>
  </widget>
@@ -142 +142 @@
   <property name="hidden_readonly_layout_modes"/>
  </widget>
- <widget name="jamb_reg_no" meta_type="StudentId Widget">
+ <widget name="jamb_reg_no" meta_type="JambRegNo Widget">
   <property name="title">JAMB Registration Number</property>
   <property name="fields">

WAeUP_SRP/trunk/skins/waeup_pins/getBatchInfo.py

@@ -32 +32 @@
         jno = item['student']
         res = context.portal_catalog(SearchableText=jno,portal_type='StudentApplication')
-        if len(res) > 1:
+        if len(res) > 0:
             item['student_url'] = "%s/%s" % (context.portal_url(),res[0].relative_path)
         else:

WAeUP_SRP/trunk/skins/waeup_student/layout_application_edit.pt

@@ -27 +27 @@
               err python:ds.getError(wid);
               err_mapping python:ds.getErrorMapping(wid);
-              is_required python: widget.is_required and creation and ('create' not in widget.readonly_layout_modes);
+              is_required python: widget.is_required;
               tooltip_id python:wid + '_help';
               widget_css_class cell/widget_css_class|nothing;

WAeUP_SRP/trunk/skins/waeup_student/passport_entry_view.pt

@@ -1 @@
-<metal:html tal:define="info context/getStudentInfo">
+<metal:html tal:define="info context/getStudentInfo;
+            rendered_main python:info['app_doc'].renderEdit(
+                                                        layout_mode='edit',
+                                                        proxy=info['app'],
+                                                        no_form = True,
+                                                        schema_id = 'student_application',
+                                                        layout_id='student_application_fe',
+            )">
   <metal:body use-macro="here/main_template/macros/master">
     <metal:main fill-slot="main">
@@ -12 +19 @@
         <h3>Upload your Passport Picture!</h3>
         <br />
-        <span tal:omit-tag=""
-              tal:content="structure python: info['app_doc'].render(proxy=info['app_doc'],
-              layout_mode='edit', 
-              layout_id='student_application_fe',
-              )" 
-              />
+        <span tal:omit-tag="" tal:replace="structure rendered_main"/>
       </span>
     </metal:main>

WAeUP_SRP/trunk/skins/waeup_student/student_edit.py

@@ -48 +48 @@
                                     use_session=True)
         action = "/passport_entry_view"
-        if app_doc.passport is not None:
-            psm = 'You successfully uploaded your passport image.'
-            args = {'apply_button': 'Apply',}
+        if is_valid:
+            if app_doc.passport is not None:
+                psm = 'You successfully uploaded your passport image.'
+                args = {'apply_button': 'Apply',}
+            else:
+                psm = "You didn't upload a passport image."
+                args = {}
         else:
-            psm = "You didn't upload a passport image."
-            args = {}
+            psm = 'psm_content_error'
+            args = getFormUidUrlArg(REQUEST)
     elif 'apply_admission' not in REQUEST.form:
         is_valid, ds = app_doc.validate(request=REQUEST,