Changeset 6980 for main/waeup.sirp

Timestamp:

1 Nov 2011, 08:34:05 (13 years ago)

Author:

Henrik Bettermann

Message:

We have to create a real (deep) list copy of self.keys() when deleting items of self. Otherwise the deletion of some of the items might fail.

I have no idea how to write regression tests with justifiable expenditure.

Location:

main/waeup.sirp/trunk/src/waeup/sirp

Files:

• imagestorage.py (modified) (1 diff)
• testing.py (modified) (1 diff)
• university/certificate.py (modified) (1 diff)

main/waeup.sirp/trunk/src/waeup/sirp/imagestorage.py

@@ -58 +58 @@
         blobs that has to be called explicitly, for instance in tests.
         """
-        key_list = self.keys()
+        key_list = list(self.keys())
         for key in key_list:
             item = self[key]

main/waeup.sirp/trunk/src/waeup/sirp/testing.py

@@ -290 +290 @@
     if collector is None:
         return
-    keys = collector.keys()
+    keys = list(collector.keys())
     for key in keys:
         del collector[key]

main/waeup.sirp/trunk/src/waeup/sirp/university/certificate.py

@@ -41 +41 @@
         """Delete a course referrer denoted by its code.
         """
-        for key in self.keys():
+        keys = list(self.keys()) # create list copy
+        for key in keys:
             if self[key].getCourseCode() != code:
                 continue