Changeset 6845 for main/waeup.sirp/trunk/src/waeup/sirp

Timestamp:

2 Oct 2011, 08:15:51 (13 years ago)

Author:

Henrik Bettermann

Message:

Do not return the student_id when calling addStudent. The student_id is now set when a student is initiated.

Location:

main/waeup.sirp/trunk/src/waeup/sirp/students

Files:

• container.py (modified) (1 diff)
• tests/test_browser.py (modified) (11 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/students/container.py

@@ -45 +45 @@
                 'StudentsContainers contain only IStudent instances')
         self[student.student_id] = student
-        # Return student_id (only needed in tests)
-        return student.student_id
+        return
 
     logger_name = 'waeup.sirp.${sitename}.students'

main/waeup.sirp/trunk/src/waeup/sirp/students/tests/test_browser.py

@@ -74 +74 @@
         student.reg_number = u'123'
         student.matric_number = u'234'
-        self.test_student_id = self.app['students'].addStudent(student)
-        self.student = self.app['students'][self.test_student_id]
+        self.app['students'].addStudent(student)
+        self.student_id = student.student_id
+        self.student = self.app['students'][self.student_id]
 
         # Set password
         IUserAccount(
-            self.app['students'][self.test_student_id]).setPassword('spwd')
+            self.app['students'][self.student_id]).setPassword('spwd')
 
         self.login_path = 'http://localhost/app/login'
@@ -85 +86 @@
         self.manage_container_path = self.container_path + '/@@manage'
         self.add_student_path = self.container_path + '/addstudent'
-        self.student_path = self.container_path + '/' + self.test_student_id
+        self.student_path = self.container_path + '/' + self.student_id
         self.manage_student_path = self.student_path + '/edit_base'
         self.clearance_student_path = self.student_path + '/view_clearance'
@@ -206 +207 @@
         self.assertTrue('Empty search string' in self.browser.contents)
         self.browser.getControl(name="searchtype").value = ['student_id']
-        self.browser.getControl(name="searchterm").value = self.test_student_id
+        self.browser.getControl(name="searchterm").value = self.student_id
         self.browser.getControl("Search").click()
         self.assertTrue('Anna Tester' in self.browser.contents)
@@ -222 +223 @@
 
         ctrl = self.browser.getControl(name='entries')
-        ctrl.getControl(value=self.test_student_id).selected = True
+        ctrl.getControl(value=self.student_id).selected = True
         self.browser.getControl("Remove selected", index=0).click()
         self.assertTrue('Successfully removed' in self.browser.contents)
         self.browser.getControl(name="searchtype").value = ['student_id']
-        self.browser.getControl(name="searchterm").value = self.test_student_id
+        self.browser.getControl(name="searchterm").value = self.student_id
         self.browser.getControl("Search").click()
         self.assertTrue('No student found' in self.browser.contents)
@@ -232 +233 @@
         self.browser.open(self.container_path)
         self.browser.getControl(name="searchtype").value = ['student_id']
-        self.browser.getControl(name="searchterm").value = self.test_student_id
+        self.browser.getControl(name="searchterm").value = self.student_id
         self.browser.getControl("Search").click()
         self.assertTrue('No student found' in self.browser.contents)
@@ -354 +355 @@
         # Managers can pass through the whole workflow
         self.browser.addHeader('Authorization', 'Basic mgr:mgrpw')
-        student = self.app['students'][self.test_student_id]
+        student = self.app['students'][self.student_id]
         self.browser.open(self.manage_student_path)
         self.assertTrue(student.clearance_locked)
@@ -391 +392 @@
         # Students can change the password
         self.browser.open(self.login_path)
-        self.browser.getControl(name="form.login").value = self.test_student_id
+        self.browser.getControl(name="form.login").value = self.student_id
         self.browser.getControl(name="form.password").value = 'spwd'
         self.browser.getControl("Login").click()
@@ -418 +419 @@
         self.browser.getLink("Login").click()
         self.browser.open(self.login_path)
-        self.browser.getControl(name="form.login").value = self.test_student_id
+        self.browser.getControl(name="form.login").value = self.student_id
         self.browser.getControl(name="form.password").value = 'new_password'
         self.browser.getControl("Login").click()
@@ -430 +431 @@
         student.reg_number = u'123456'
         student.fullname = u'Klaus Tester'
-        test_student_id = self.app['students'].addStudent(student)
+        self.app['students'].addStudent(student)
         setpassword_path = 'http://localhost/app/setpassword'
-        student_path = 'http://localhost/app/students/%s' % test_student_id
+        student_path = 'http://localhost/app/students/%s' % student.student_id
         self.browser.open(setpassword_path)
         self.browser.getControl(name="ac_series").value = self.existing_pwdseries
@@ -465 +466 @@
         # The student can login with the new credentials
         self.browser.open(self.login_path)
-        self.browser.getControl(name="form.login").value = test_student_id
+        self.browser.getControl(name="form.login").value = student.student_id
         self.browser.getControl(
             name="form.password").value = self.existing_pwdnumber
@@ -476 +477 @@
         # Students can access their own objects
         # and can perform actions
-        student = self.app['students'][self.test_student_id]
+        student = self.app['students'][self.student_id]
         IWorkflowInfo(student).fireTransition('admit')
         self.browser.open(self.login_path)
-        self.browser.getControl(name="form.login").value = self.test_student_id
+        self.browser.getControl(name="form.login").value = self.student_id
         self.browser.getControl(name="form.password").value = 'spwd'
         self.browser.getControl("Login").click()