Changeset 6819

Timestamp:

27 Sep 2011, 08:07:54 (13 years ago)

Author:

Henrik Bettermann

Message:

We should be very strict when importing dates and allow only one import format: YYYY-MM-DD.

Overwrite the DateWidget? by the FormattedDateWidget?, already defined in the widgets package, to generally bypass Python's parseDatetimetz module which is used by the original DateWidget?. parseDatetimetz is too dangerous when used in importers.

Location:

main/waeup.sirp/trunk/src/waeup/sirp/utils

Files:

• overrides.zcml (modified) (1 diff)
• tests/test_converters.py (modified) (1 diff)

main/waeup.sirp/trunk/src/waeup/sirp/utils/overrides.zcml

@@ -9 +9 @@
       />
 
+  <adapter
+      for="zope.schema.interfaces.IDate
+           zope.publisher.interfaces.browser.IBrowserRequest"
+      provides="zope.formlib.interfaces.ISimpleInputWidget"
+      factory="waeup.sirp.widgets.datewidget.FormattedDateWidget"
+      permission="zope.Public"
+      />
+
 </configure>

main/waeup.sirp/trunk/src/waeup/sirp/utils/tests/test_converters.py

@@ -250 +250 @@
         contact = Contact()
         converter = IObjectConverter(IContact) # a converter to IContact
-        err, inv_err, data = converter.fromStringDict(
-            dict(birthday='1945/12/23'), contact)
+
+        # The input format for dates: YYYY-MM-DD
+        err, inv_err, data = converter.fromStringDict(
+            dict(birthday='1945-12-23'), contact)
         assert data['birthday'] == datetime.date(1945, 12, 23)
         assert isinstance(data['birthday'], datetime.date)
 
         err, inv_err, data = converter.fromStringDict(
-            dict(birthday='1945/23/12'), contact)
-        assert data['birthday'] == datetime.date(1945, 12, 23)
-
-        # The preferred input format for dates: YYYY-MM-DD
-        err, inv_err, data = converter.fromStringDict(
-            dict(birthday='1945-12-23'), contact)
-        assert data['birthday'] == datetime.date(1945, 12, 23)
+            dict(birthday='1945-23-12'), contact)
+        #import pdb; pdb.set_trace()
+        #assert data['birthday'] == datetime.date(1945, 12, 23)
+        assert err[0][1] =='Invalid datetime data'
 
         # '08' is not interpreted as octal number