Changeset 6754 for main/waeup.sirp/trunk/src/waeup/sirp

Timestamp:

14 Sep 2011, 00:48:11 (13 years ago)

Author:

uli

Message:

Logger-related stuff.

Location:

main/waeup.sirp/trunk/src/waeup/sirp

Files:

• browser/batchprocessing.txt (modified) (1 diff)
• interfaces.py (modified) (1 diff)
• testing.py (modified) (2 diffs)
• utils/logger.py (modified) (3 diffs)
• utils/tests/test_logger.py (modified) (7 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/browser/batchprocessing.txt

@@ -557 +557 @@
     >>> 'datacenter.log' in browser.contents
     True
-    >>> browser.getControl('Show', index=1).click()
+    >>> browser.getControl('Show', index=0).click()
     >>> '<input type="submit" name="back" value="Back" />' in browser.contents
     True

main/waeup.sirp/trunk/src/waeup/sirp/interfaces.py

@@ -484 +484 @@
         paths.
         """
+
+class ILoggerCollector(Interface):
+
+    def getLoggers(site):
+        """Return all loggers registered for `site`.
+        """
+
+    def registerLogger(site, logging_component):
+        """Register a logging component residing in `site`.
+        """
+
+    def unregisterLogger(site, logging_component):
+        """Unregister a logger.
+        """

main/waeup.sirp/trunk/src/waeup/sirp/testing.py

@@ -284 +284 @@
     doctest.REPORT_NDIFF + doctest.ELLIPSIS + doctest.NORMALIZE_WHITESPACE)
 
+def clear_logger_collector():
+    from zope.component import queryUtility, getGlobalSiteManager
+    from waeup.sirp.interfaces import ILoggerCollector
+    collector = queryUtility(ILoggerCollector)
+    if collector is None:
+        return
+    keys = collector.keys()
+    for key in keys:
+        del collector[key]
+    return
+
 class FunctionalTestCase(FunctionalTestCase):
     """A test case that supports checking output diffs in doctest style.
@@ -296 +307 @@
         super(FunctionalTestCase, self).tearDown()
         remove_new_loggers(self.functional_old_loggers)
+        clear_logger_collector()
         return
 

main/waeup.sirp/trunk/src/waeup/sirp/utils/logger.py

@@ -84 +84 @@
 from zope.component import queryUtility
 from zope.interface import Interface, Attribute, implements
-from waeup.sirp.interfaces import IDataCenter, IDataCenterStorageMovedEvent
+from waeup.sirp.interfaces import (
+    IDataCenter, IDataCenterStorageMovedEvent, ILoggerCollector)
 
 #: Default logfile size (5 KB)
@@ -300 +301 @@
 
 
-class ILoggerCollector(Interface):
-
-    def getLoggers(site):
-        """Return all loggers registered for `site`.
-        """
-
-    def registerLogger(site, logging_component):
-        """Register a logging component residing in `site`.
-        """
-
-    def unregisterLogger(site, logging_component):
-        """Unregister a logger.
-        """
-
 class LoggerCollector(dict, grok.GlobalUtility):
     """A global utility providing `ILoggerCollector`.
@@ -380 +367 @@
             logger.logger_logfile_changed()
     return
+
+from waeup.sirp.interfaces import IUniversity
+@grok.subscribe(IUniversity, grok.IObjectRemovedEvent)
+def handle_site_removal(obj, event):
+    collector = queryUtility(ILoggerCollector)
+    name = getattr(obj, '__name__', None)
+    if name is None:
+        return
+    if name not in collector.keys():
+        return
+    del collector[name]
+    return

main/waeup.sirp/trunk/src/waeup/sirp/utils/tests/test_logger.py

@@ -8 +8 @@
 from zope.interface.verify import verifyClass, verifyObject
 from waeup.sirp.app import University
-from waeup.sirp.testing import (
-    FunctionalLayer, FunctionalTestCase, get_all_loggers,
-    remove_new_loggers, remove_logger)
+from waeup.sirp.testing import FunctionalLayer, FunctionalTestCase
 
 from waeup.sirp.utils.logger import (
@@ -259 +257 @@
     def setUp(self):
         super(LoggerCollectorTests, self).setUp()
-        self.old_loggers = get_all_loggers()
         # Setup a sample site for each test
         app = University()
@@ -281 +278 @@
     def tearDown(self):
         super(LoggerCollectorTests, self).tearDown()
-        remove_new_loggers(self.old_loggers)
         shutil.rmtree(self.workdir)
         shutil.rmtree(self.dc_root)
@@ -357 +353 @@
     def setUp(self):
         super(LogfileChangeTests, self).setUp()
-        remove_logger('waeup.sirp.app') # In case it lingers around
-        self.old_loggers = get_all_loggers()
         # Setup a sample site for each test
         app = University()
@@ -373 +367 @@
         self.component = self.app['mycomponent']
         setSite(self.app)
-
         self.component = LoggingComponent()
         return
@@ -379 +372 @@
     def tearDown(self):
         super(LogfileChangeTests, self).tearDown()
-        remove_new_loggers(self.old_loggers)
         shutil.rmtree(self.workdir)
         shutil.rmtree(self.dc_root)
@@ -397 +389 @@
         self.assertTrue(filename2.startswith(self.dc_root_new))
         return
+
+    def test_storage_deletion(self):
+        # When a site is deleted, the loggers should go away as well
+        self.dc_root_new = tempfile.mkdtemp()
+        logger1 = self.component.logger.handlers # create entry in collector
+        collector = queryUtility(ILoggerCollector)
+        loggers1 = collector.keys()
+        root = self.app.__parent__
+        del root['app']
+        loggers2 = collector.keys()
+        self.assertEqual(loggers1, ['app'])
+        self.assertEqual(loggers2, [])
+        return