Changeset 6662 for main

Timestamp:

3 Sep 2011, 02:27:24 (13 years ago)

Author:

uli

Message:

• Use stronger randomization.
• Make student ids unicode (required when used in interfaces).

File:

• main/waeup.sirp/trunk/src/waeup/sirp/students/utils.py (modified) (1 diff)

main/waeup.sirp/trunk/src/waeup/sirp/students/utils.py

@@ -2 +2 @@
 """
 
-import random
+from random import SystemRandom as r
 from waeup.sirp.students.catalog import search
 
 def generate_student_id(letter):
-    r = random
+    # XXX: using catalog search here might be overkill?
     if letter == '?':
         letter= r.choice('ABCDEFGHKLMNPQRSTUVWXY')
-    sid = "%c%d" % (letter,r.randint(99999,1000000))
+    sid = u"%c%d" % (letter,r.randint(99999,1000000))
     while search(query=sid,searchtype='student_id'):
-        sid = "%c%d" % (letter,r.randint(99999,1000000))
+        sid = u"%c%d" % (letter,r.randint(99999,1000000))
     return sid