Changeset 6470

Timestamp:

23 Jun 2011, 12:31:09 (13 years ago)

Author:

Henrik Bettermann

Message:

It should always be workflow state not status. My mistake.

Location:

main/waeup.sirp/trunk/src/waeup/sirp

Files:

• accesscodes/accesscodes.py (modified) (4 diffs)
• accesscodes/browser.txt (modified) (1 diff)
• accesscodes/browser_templates/searchpage.pt (modified) (2 diffs)
• accesscodes/catalog.py (modified) (2 diffs)
• accesscodes/interfaces.py (modified) (1 diff)
• accesscodes/tests/test_accesscodes.py (modified) (2 diffs)
• accesscodes/tests/test_catalog.py (modified) (4 diffs)
• applicants/authentication.py (modified) (1 diff)
• applicants/browser.py (modified) (1 diff)
• applicants/browser_templates/applicantscontainermanagepage.pt (modified) (1 diff)
• applicants/tests/test_authentication.py (modified) (1 diff)

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/accesscodes.py

@@ -52 +52 @@
 
     @property
-    def status(self):
+    def state(self):
         return IWorkflowState(self).getState()
 
@@ -166 +166 @@
             )
         writer = csv.writer(open(csv_path, 'w'), quoting=csv.QUOTE_ALL)
-        writer.writerow(['prefix', 'serial', 'ac', 'status', 'history'])
+        writer.writerow(['prefix', 'serial', 'ac', 'state', 'history'])
         writer.writerow([self.prefix, '%0.2f' % self.cost, str(self.num),
                          str(self.entry_num)])
@@ -175 +175 @@
             writer.writerow([
                     self.prefix, value.batch_serial, value.representation,
-                    value.status, value.history
+                    value.state, value.history
                     ])
         return os.path.basename(csv_path)
@@ -251 +251 @@
 
     # This is temporary reimport solution. Access codes will be imported
-    # with status initialized no matter if they have been used before.
+    # with state initialized no matter if they have been used before.
     def reimport(self, filename, creator=u'UNKNOWN'):
         """Reimport a batch given in CSV file.

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/browser.txt

@@ -306 +306 @@
     ...                             sorted(os.listdir(ac_storage))[-2])
     >>> print open(archive_file, 'rb').read()
-    "prefix","serial","ac","status","history"
+    "prefix","serial","ac","state","history"
     "BLA","19.12","1","3"
     "BLA","0","BLA-1-<10-DIGITS>","initialized","..."

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/browser_templates/searchpage.pt

@@ -25 +25 @@
         <tr>
           <th>&nbsp;</th>
-          <th width="50px">Serial</th><th>AC</th><th>Status</th><th>History</th>
+          <th width="50px">Serial</th><th>AC</th><th>State</th><th>History</th>
         </tr>
       </thead>
@@ -34 +34 @@
           <td tal:content="item/batch_serial">1</td>
           <td tal:content="item/code">APP-1-1234567890</td>
-          <td tal:content="item/status">unused</td>
+          <td tal:content="item/state">unused</td>
           <td tal:content="structure python:item.history.replace('||','<br />')">
             history

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/catalog.py

@@ -18 +18 @@
     history = grok.index.Text(attribute='history')
     batch_serial = grok.index.Field(attribute='batch_serial')
-    status = grok.index.Field(attribute='status')
+    state = grok.index.Field(attribute='state')
 
 class AccessCodeQueryResultItem(object):
@@ -28 +28 @@
         self.code = context.representation
         self.history = context.history
-        self.status = context.status
+        self.state = context.state
         self.batch_serial = context.batch_serial
 

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/interfaces.py

@@ -24 +24 @@
         default = 0.0, min = 0.0,
         )
-    status = schema.TextLine(
-        title = u'Workflow status',
+    state = schema.TextLine(
+        title = u'Workflow state',
         )
     representation = schema.TextLine(

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/tests/test_accesscodes.py

@@ -106 +106 @@
 
     def test_invalidate_accesscode(self):
-        assert self.ac1.status != USED
+        assert self.ac1.state != USED
         result = invalidate_accesscode('APP-1-11111111')
-        assert self.ac1.status == USED
+        assert self.ac1.state == USED
         assert result is True
 
     def test_disable_accesscode_unused(self):
         # we can disable initialized acs
-        assert self.ac1.status != USED
+        assert self.ac1.state != USED
         disable_accesscode('APP-1-11111111')
-        assert self.ac1.status == DISABLED
+        assert self.ac1.state == DISABLED
 
     def test_disable_accesscode_used(self):
         # we can disable already used acs
-        assert self.ac1.status != DISABLED
+        assert self.ac1.state != DISABLED
         invalidate_accesscode('APP-1-11111111')
         disable_accesscode('APP-1-11111111')
-        assert self.ac1.status == DISABLED
+        assert self.ac1.state == DISABLED
 
     def test_reenable_accesscode(self):
@@ -129 +129 @@
         result = reenable_accesscode('APP-1-11111111')
         assert result is True
-        assert self.ac1.status != USED
+        assert self.ac1.state != USED
 
     def test_fire_transition(self):

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/tests/test_catalog.py

@@ -110 +110 @@
         # Now we want to find the disabled access code
         cat = queryUtility(ICatalog, name='accesscodes_catalog')
-        results1 = cat.searchResults(status=('disabled', 'disabled'))
-        results2 = cat.searchResults(status=('initialized', 'initialized'))
+        results1 = cat.searchResults(state=('disabled', 'disabled'))
+        results2 = cat.searchResults(state=('initialized', 'initialized'))
         results1 = [x for x in results1] # Turn results generator into list
         # We found 1 accescode disabled
@@ -125 +125 @@
         # Now we want to find the invalidated access code
         cat = queryUtility(ICatalog, name='accesscodes_catalog')
-        results1 = cat.searchResults(status=('used', 'used'))
-        results2 = cat.searchResults(status=('initialized', 'initialized'))
+        results1 = cat.searchResults(state=('used', 'used'))
+        results2 = cat.searchResults(state=('initialized', 'initialized'))
         results1 = [x for x in results1] # Turn results generator into list
         # We found 1 accescode used
@@ -145 +145 @@
         # exactly one access code.
         results = cat.searchResults(history='Tester',
-                                    status=('used', 'used'),
+                                    state=('used', 'used'),
                                     code=('APP-1-11111111', 'APP-1-22222222'))
         assert len(results) == 1
@@ -154 +154 @@
         # immediately in catalog
         cat = queryUtility(ICatalog, name='accesscodes_catalog')
-        result = cat.searchResults(status=('used', 'used'))
+        result = cat.searchResults(state=('used', 'used'))
         assert len(result) == 0
         invalidate_accesscode('APP-1-11111111')
-        result = cat.searchResults(status=('used', 'used'))
+        result = cat.searchResults(state=('used', 'used'))
         assert len(result) == 1

main/waeup.sirp/trunk/src/waeup/sirp/applicants/authentication.py

@@ -228 +228 @@
         if ac is None:
             return None
-        if ac.status == 'disabled':
-            return None
-        if ac.status == 'used' and appl_ac != ac.representation:
+        if ac.state == 'disabled':
+            return None
+        if ac.state == 'used' and appl_ac != ac.representation:
             return None
         if appl_ac is not None and appl_ac != ac.representation:

main/waeup.sirp/trunk/src/waeup/sirp/applicants/browser.py

@@ -426 +426 @@
 
         # Mark pin as used (this also fires a pin related transition)
-        if get_access_code(pin).status == USED:
+        if get_access_code(pin).state == USED:
             pass
         else:

main/waeup.sirp/trunk/src/waeup/sirp/applicants/browser_templates/applicantscontainermanagepage.pt

@@ -65 +65 @@
             <th>ID
             </th>
-            <th>status
+            <th>state
             </th>
           </tr>

main/waeup.sirp/trunk/src/waeup/sirp/applicants/tests/test_authentication.py

@@ -50 +50 @@
 
 class FakeAccessCode(object):
-    def __init__(self, repr, status = 'initialized'):
+    def __init__(self, repr, state = 'initialized'):
         self.representation = repr
-        self.status = status
+        self.state = state
 
 class FakeApplication(object):