Changeset 6452 for main/waeup.sirp/trunk/src/waeup/sirp/accesscodes

Timestamp:

22 Jun 2011, 13:51:55 (14 years ago)

Author:

Henrik Bettermann

Message:

Replace properties 'used' and 'disabled' by 'status'.

Location:

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes

Files:

• accesscodes.py (modified) (5 diffs)
• browser.txt (modified) (1 diff)
• browser_templates/reimportbatchpage.pt (modified) (1 diff)
• catalog.py (modified) (1 diff)
• interfaces.py (modified) (1 diff)
• tests/test_accesscodes.py (modified) (2 diffs)
• tests/test_catalog.py (modified) (4 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/accesscodes.py

@@ -56 +56 @@
 
     @property
-    def disabled(self):
-        return IWorkflowState(self).getState() == DISABLED
-
-    @property
-    def used(self):
-        return IWorkflowState(self).getState() == USED
-
-    @property
     def history(self):
         history = IObjectHistory(self)
@@ -174 +166 @@
             )
         writer = csv.writer(open(csv_path, 'w'), quoting=csv.QUOTE_ALL)
-        writer.writerow(['prefix', 'serial', 'ac', 'used',
-                         'disabled', 'history'])
+        writer.writerow(['prefix', 'serial', 'ac', 'status', 'history'])
         writer.writerow([self.prefix, '%0.2f' % self.cost, str(self.num),
                          str(self.entry_num)])
@@ -184 +175 @@
             writer.writerow([
                     self.prefix, value.batch_serial, value.representation,
-                    value.used and '1' or '0', value.disabled and '1' or '0',
-                    value.history
+                    value.status, value.history
                     ])
         return os.path.basename(csv_path)
@@ -292 +282 @@
         return
 
-    #def search(self, searchterm, searchtype):
-    #    """Look for access-codes that comply with the given params.
-    #    """
-    #    results = []
-    #    return results
-
     def getAccessCode(self, ac_id):
         """Get the AccessCode with ID ``ac_id`` or ``KeyError``.
@@ -332 +316 @@
         reenable_accesscode(ac_id, user_id)
         return
-
-    #def invalidate(self, ac_id):
-    #    """Invalidate the AC with ID ``ac_id``.
-    #    """
-    #    ac = self.getAccessCode(ac_id)
-    #    if ac is None:
-    #        return
-    #    ac.__parent__.invalidate(ac_id)
-    #    return
-
 
 class AccessCodePlugin(grok.GlobalUtility):

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/browser.txt

@@ -306 +306 @@
     ...                             sorted(os.listdir(ac_storage))[-2])
     >>> print open(archive_file, 'rb').read()
-    "prefix","serial","ac","used","disabled","history"
+    "prefix","serial","ac","status","history"
     "BLA","19.12","1","3"
-    "BLA","0","BLA-1-<10-DIGITS>","0","0","..."
-    "BLA","1","BLA-1-<10-DIGITS>","0","0","..."
-    "BLA","2","BLA-1-<10-DIGITS>","0","0","..."
+    "BLA","0","BLA-1-<10-DIGITS>","initialized","..."
+    "BLA","1","BLA-1-<10-DIGITS>","initialized","..."
+    "BLA","2","BLA-1-<10-DIGITS>","initialized","..."
 
 Clean up:

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/browser_templates/reimportbatchpage.pt

@@ -1 @@
-<h3>Reimport Access-Code Batches</h3>
+<h3>Reimport Access Code Batches</h3>
 <p>
   Please select the files to reimport. Please note, that batches with

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/catalog.py

@@ -17 +17 @@
     code = grok.index.Field(attribute='representation')
     history = grok.index.Text(attribute='history')
-    disabled = grok.index.Field(attribute='disabled')
-    used = grok.index.Field(attribute='used')
     batch_serial = grok.index.Field(attribute='batch_serial')
     status = grok.index.Field(attribute='status')

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/interfaces.py

@@ -26 +26 @@
     status = schema.TextLine(
         title = u'Workflow status',
-        )
-    disabled = schema.Bool(
-        title = u'Access code is disabled',
-        default = False,
-        readonly = True,
-        )
-    used = schema.Bool(
-        title = u'Access code is already in use.',
-        default = False,
-        readonly = True,
         )
     representation = schema.TextLine(

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/tests/test_accesscodes.py

@@ -106 +106 @@
 
     def test_invalidate_accesscode(self):
-        assert self.ac1.used is False
+        assert self.ac1.status != USED
         result = invalidate_accesscode('APP-1-11111111')
-        assert self.ac1.used is True
+        assert self.ac1.status == USED
         assert result is True
 
     def test_disable_accesscode_unused(self):
         # we can disable initialized acs
-        assert self.ac1.disabled is False
+        assert self.ac1.status != USED
         disable_accesscode('APP-1-11111111')
-        assert self.ac1.disabled is True
+        assert self.ac1.status == DISABLED
 
     def test_disable_accesscode_used(self):
         # we can disable already used acs
-        assert self.ac1.disabled is False
+        assert self.ac1.status != DISABLED
         invalidate_accesscode('APP-1-11111111')
         disable_accesscode('APP-1-11111111')
-        assert self.ac1.disabled is True
+        assert self.ac1.status == DISABLED
 
     def test_reenable_accesscode(self):
@@ -129 +129 @@
         result = reenable_accesscode('APP-1-11111111')
         assert result is True
-        assert self.ac1.disabled is False
+        assert self.ac1.status != USED
 
     def test_fire_transition(self):

main/waeup.sirp/trunk/src/waeup/sirp/accesscodes/tests/test_catalog.py

@@ -110 +110 @@
         # Now we want to find the disabled access code
         cat = queryUtility(ICatalog, name='accesscodes_catalog')
-        results1 = cat.searchResults(disabled=(True, True))
-        results2 = cat.searchResults(disabled=(False, False))
+        results1 = cat.searchResults(status=('disabled', 'disabled'))
+        results2 = cat.searchResults(status=('initialized', 'initialized'))
         results1 = [x for x in results1] # Turn results generator into list
         # We found 1 accescode disabled
@@ -125 +125 @@
         # Now we want to find the invalidated access code
         cat = queryUtility(ICatalog, name='accesscodes_catalog')
-        results1 = cat.searchResults(used=(True, True))
-        results2 = cat.searchResults(used=(False, False))
+        results1 = cat.searchResults(status=('used', 'used'))
+        results2 = cat.searchResults(status=('initialized', 'initialized'))
         results1 = [x for x in results1] # Turn results generator into list
         # We found 1 accescode used
@@ -145 +145 @@
         # exactly one access code.
         results = cat.searchResults(history='Tester',
-                                    used=(True, True),
+                                    status=('used', 'used'),
                                     code=('APP-1-11111111', 'APP-1-22222222'))
         assert len(results) == 1
@@ -154 +154 @@
         # immediately in catalog
         cat = queryUtility(ICatalog, name='accesscodes_catalog')
-        result = cat.searchResults(used=(True, True))
+        result = cat.searchResults(status=('used', 'used'))
         assert len(result) == 0
         invalidate_accesscode('APP-1-11111111')
-        result = cat.searchResults(used=(True, True))
+        result = cat.searchResults(status=('used', 'used'))
         assert len(result) == 1