Changeset 6322

Timestamp:

10 Jun 2011, 06:58:09 (13 years ago)

Author:

Henrik Bettermann

Message:

• Use user_data attribute to display more appropriate workflow messages.

• confirm_passport must not be an attribute of Applicant. Use confirm_passport only in form to allow submission.

• application_state must not be an attribute of Applicant.

Location:

main/waeup.sirp/trunk/src/waeup/sirp/applicants

Files:

• applicants.py (modified) (1 diff)
• browser.py (modified) (7 diffs)
• browser_templates/form_edit.pt (modified) (2 diffs)
• interfaces.py (modified) (4 diffs)
• workflow.py (modified) (13 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/applicants/applicants.py

@@ -47 +47 @@
     def __init__(self):
         super(Applicant, self).__init__()
+        timestamp = datetime.now().strftime("%d/%m/%Y %H:%M")
         #Initialize workflow state...
         IWorkflowInfo(self).fireTransition('init')
-        timestamp = datetime.now().strftime("%d/%m/%Y %H:%M")
-        self.messages = u'%s - Initialize application' % timestamp
 
 # Set all attributes of Applicant required in IApplicant as field

main/waeup.sirp/trunk/src/waeup/sirp/applicants/browser.py

@@ -76 +76 @@
 TRANSITION_OBJECTS = create_workflow()
 
-TRANSITION_DICT = dict([
-    (transition_object.transition_id,transition_object.title)
-    for transition_object in TRANSITION_OBJECTS])
+#TRANSITION_DICT = dict([
+#    (transition_object.transition_id,transition_object.title)
+#    for transition_object in TRANSITION_OBJECTS])
 
 class ApplicantsRootPage(WAeUPPage):
@@ -419 +419 @@
         if state == INITIALIZED:
             IWorkflowInfo(self.context[pin]).fireTransition('start')
-            timestamp = datetime.now().strftime("%d/%m/%Y %H:%M")
-            transition_title = TRANSITION_DICT['start']
-            self.context[pin].messages += '<br />%s - %s' % (
-                timestamp,transition_title)
         self.redirect(self.url(self.context[pin], 'edit'))
         return
@@ -496 +492 @@
     form_fields['date_of_birth'].custom_widget = FriendlyDateWidget('le-year')
     grok.template('form_edit')
+    manage_applications = True
     pnav = 3
 
@@ -551 +548 @@
     form_fields['date_of_birth'].custom_widget = FriendlyDateWidget('le-year')
     grok.template('form_edit')
+    manage_applications = False
+
 
     def emitLockMessage(self):
@@ -566 +565 @@
 
     def dataNotComplete(self):
-        if self.context.confirm_passport is not True:
+        #import pdb; pdb.set_trace()
+        if not self.request.form.get('confirm_passport', False):
             return 'Passport confirmation box not ticked.'
         if len(self.errors) > 0:
@@ -572 +572 @@
         return False
 
-    @property
-    def getTransitions(self):
-        return None
-
     @grok.action('Save')
     def save(self, **data):
@@ -597 +593 @@
             return
         state = IWorkflowState(self.context).getState()
-        # Cannot happen but anyway ...
+        # This shouldn't happen, but the application officer
+        # might have forgotten to lock the form after changing the state
         if state != STARTED:
-            self.flash('This form cannot be submitted.')
+            self.flash('This form cannot be submitted. Wrong state!')
             return
         IWorkflowInfo(self.context).fireTransition('submit')

main/waeup.sirp/trunk/src/waeup/sirp/applicants/browser_templates/form_edit.pt

@@ -54 +54 @@
         </tr>
       </tal:block>
-        <tr tal:condition="view/getTransitions">
+        <tr tal:condition="view/manage_applications">
         <td class="label"><label>Application Transition:</label></td>
         <td>
@@ -68 +68 @@
   </table>
 
+  <p tal:condition="not: view/manage_applications">
+    <input class="checkboxType" id="confirm_passport" name="confirm_passport" type="checkbox" value="True"/>
+    I confirm that the Passport Photograph uploaded on this form is a true picture of me.
+  </p>
+
   <div id="actionsView">
     <span class="actionButtons" tal:condition="view/availableActions">

main/waeup.sirp/trunk/src/waeup/sirp/applicants/interfaces.py

@@ -347 +347 @@
         max_size = 20480,
         )
-    confirm_passport = schema.Bool(
-        title = u"Passport picture confirmed",
-        default = False,
-        required = True,
-        )
+
     #
     # Process Data
@@ -408 +404 @@
     omit fields. This has to be done in the respective form page.
     """
-    application_state = Attribute("The workflow state of an applicant object.")
-
     screening_score = schema.Int(
         title = u'Screening Score',
@@ -427 +421 @@
         readonly = True,
         )
-    entry_session = schema.TextLine(
-        # XXX: should be choice
+    entry_session = schema.Choice(
+        source = entry_session_vocab,
         title = u'Entry Session',
         required = False,
-        readonly = True,
+        readonly = True
         )
     notice = schema.Text(
@@ -437 +431 @@
         required = False,
         readonly = True,
-        )
-    confirm_passport = schema.Bool(
-        title = u"I confirm that the Passport Photograph uploaded on this form is a true picture of me.",
-        default = False,
-        required = True,
         )
 

main/waeup.sirp/trunk/src/waeup/sirp/applicants/workflow.py

@@ -25 +25 @@
         source = None,
         condition = NullCondition,
+        msg = 'appplication process initialized',
         destination = INITIALIZED)
 
@@ -30 +31 @@
         transition_id = 'start',
         title = 'Start application',
+        msg = 'appplication process started',
         source = INITIALIZED,
         destination = STARTED)
@@ -36 +38 @@
         transition_id = 'submit',
         title = 'Submit application',
+        msg = 'appplication record submitted',
         source = STARTED,
         destination = SUBMITTED)
@@ -42 +45 @@
         transition_id = 'admit',
         title = 'Admit applicant',
+        msg = 'appplicant admitted',
         source = SUBMITTED,
         destination = ADMITTED)
@@ -48 +52 @@
         transition_id = 'refuse1',
         title = 'Refuse application',
+        msg = 'appplication refused',
         source = SUBMITTED,
         destination = NOT_ADMITTED)
@@ -54 +59 @@
         transition_id = 'refuse2',
         title = 'Refuse application',
+        msg = 'appplication refused',
         source = ADMITTED,
         destination = NOT_ADMITTED)
@@ -60 +66 @@
         transition_id = 'create',
         title = 'Create student record',
+        msg = 'student record created',
         source = ADMITTED,
         destination = CREATED)
@@ -66 +73 @@
         transition_id = 'reset1',
         title = 'Reset application',
+        msg = 'appplication record reset',
         source = SUBMITTED,
         destination = STARTED)
@@ -72 +80 @@
         transition_id = 'reset2',
         title = 'Reset application',
+        msg = 'appplication record reset',
         source = ADMITTED,
         destination = STARTED)
@@ -78 +87 @@
         transition_id = 'reset3',
         title = 'Reset application',
+        msg = 'appplication record reset',
         source = NOT_ADMITTED,
         destination = STARTED)
@@ -84 +94 @@
         transition_id = 'reset4',
         title = 'Reset application',
+        msg = 'appplication record reset',
         source = CREATED,
         destination = STARTED)
@@ -161 +172 @@
     """
     timestamp = datetime.now().strftime("%d/%m/%Y %H:%M:%S")
-    comment = event.comment or '(no comment)'
     # XXX: `messages` is meta data which shouldn't really be part of
     #      the Applicant class. Furthermore we should not store HTML
@@ -169 +179 @@
     #      to finetune transitions instead of doing that manually in
     #      UI stuff.
-    msg = '%s - %s to %s: %s: %s' % (
-        timestamp, event.source, event.destination, event.transition.title,
-        comment)
+    msg = '%s - %s (new state: %s)' % (
+        timestamp, event.transition.user_data['msg'], event.destination)
     msgs = getattr(obj, 'messages', None)
-    if msgs != '':
+    if msgs:
         msgs += '<br />'
-    obj.messages += msg
+        msgs += msg
+    else:
+        msgs = msg
+    obj.messages = msgs
     return