Changeset 6233

Timestamp:

30 May 2011, 00:22:11 (13 years ago)

Author:

uli

Message:

Replace old clear() implementation with a call to internal function
implemented in C. This way we not only get tremendous speedup for the
clear-action but also kick a faulty implementation. The old one
removed only half of the items contained and the test didn't check
that properly.

File:

• main/waeup.sirp/trunk/src/waeup/sirp/university/certificatecontainer.py (modified) (1 diff)

main/waeup.sirp/trunk/src/waeup/sirp/university/certificatecontainer.py

@@ -39 +39 @@
 
     def clear(self):
-        keys = self.keys()
-        for key in keys:
-            del self[key]
+        """Remove all contents from the certificate container.
+        """
+        # This internal function is implemented in C and thus much
+        # faster as we could do it in pure Python.
+        self._SampleContainer__data.clear()
+        # The length attribute is 'lazy'. See `zope.container` for details.
+        # This way we make sure, the next time len() is called, it returns
+        # the real value and not a cached one.
+        del self.__dict__['_BTreeContainer__len']
 
 class CertificateContainerFactory(grok.GlobalUtility):