Changeset 5988 for main/waeup.sirp

Timestamp:

27 Apr 2011, 07:43:49 (13 years ago)

Author:

Henrik Bettermann

Message:

Implement title_prefix vocabulary. Remove redundant getName method and replace by the longtitle property.

Location:

main/waeup.sirp/trunk/src/waeup/sirp

Files:

• browser/breadcrumbs.py (modified) (1 diff)
• browser/pages.py (modified) (3 diffs)
• browser/templates/facultycontainerpage.pt (modified) (1 diff)
• browser/templates/facultypage.pt (modified) (1 diff)
• tables.py (modified) (2 diffs)
• university/department.py (modified) (2 diffs)
• university/faculty.py (modified) (2 diffs)
• university/facultycontainer.py (modified) (1 diff)
• university/interfaces.py (modified) (4 diffs)
• university/vocabularies.py (modified) (1 diff)
• utils/helpers.py (modified) (1 diff)

main/waeup.sirp/trunk/src/waeup/sirp/browser/breadcrumbs.py

@@ -121 +121 @@
     @property
     def title(self):
-        prefix = self.context.title_prefix
-        prefix = prefix[0].upper() + prefix[1:]
-        return '%s of %s' % (prefix, self.context.title)
+        return self.context.longtitle()
 
 class DepartmentBreadcrumb(FacultyBreadcrumb):

main/waeup.sirp/trunk/src/waeup/sirp/browser/pages.py

@@ -41 +41 @@
     IWAeUPXMLImporter, IWAeUPXMLExporter, IBatchProcessor)
 from waeup.sirp.university.catalog import search
-from waeup.sirp.utils.helpers import getName
 from waeup.sirp.widgets.interfaces import ITableProvider
 
@@ -905 +904 @@
     grok.name('index')
     pnav = 1
+
     @property
     def title(self):
-        return "%s (%s)" % (getName(self.context), self.context.code)
+        return self.context.longtitle()
 
     #def update(self, code=None, edit=None, delete=None):
@@ -995 +995 @@
     grok.name('index')
     pnav = 1
+    #title = 'xxx'
 
     @property
     def title(self):
-        return "%s (%s)" % (getName(self.context), self.context.code)
+        #import pdb; pdb.set_trace()
+        return self.context.longtitle()
     
     def update(self):

main/waeup.sirp/trunk/src/waeup/sirp/browser/templates/facultycontainerpage.pt

@@ -15 +15 @@
     <tr tal:repeat="value context/values">
       <td> <a tal:attributes="href value/__name__"> <span tal:content="value/code">Name</span></a></td>
-      <td tal:content="value/title">Title</td>
+      <td tal:content="value/longtitle">Title</td>
     </tr>
   </tbody>

main/waeup.sirp/trunk/src/waeup/sirp/browser/templates/facultypage.pt

@@ -15 +15 @@
     <tr tal:repeat="value context/values">
       <td> <a tal:attributes="href value/__name__"> <span tal:content="value/code">Name</span></a></td>
-      <td tal:content="value/title">Title</td>
+      <td tal:content="value/longtitle">Title</td>
       <td class="text-right">
       </td>

main/waeup.sirp/trunk/src/waeup/sirp/tables.py

@@ -6 +6 @@
 from waeup.sirp.widgets.table import YUITable as Table
 from waeup.sirp.widgets.table import Col
-from waeup.sirp.utils.helpers import getName
 
 class CodeAndTitleTableProvider(grok.Adapter):
@@ -42 +41 @@
             Col(
                 header='Title', sortable=True,
-                data = tuple([getName(data[x]) for x in data])),
+                data = tuple([data[x] for x in data])),
             )
         self.table = Table(self.title, cols=cols)

main/waeup.sirp/trunk/src/waeup/sirp/university/department.py

@@ -6 +6 @@
 from zope.interface import implementedBy
 from waeup.sirp.university.interfaces import IDepartment, IDepartmentAdd
+from waeup.sirp.university.vocabularies import inst_types
 
 class Department(grok.Container):
@@ -40 +41 @@
         return None
         
+    def longtitle(self):
+        return "%s %s (%s)" % (inst_types.getTerm(self.title_prefix).title, 
+                                                  self.title,
+                                                  self.code)
+        
 
 class DepartmentFactory(grok.GlobalUtility):

main/waeup.sirp/trunk/src/waeup/sirp/university/faculty.py

@@ -7 +7 @@
 from waeup.sirp.university.interfaces import (
     IFaculty, IFacultyAdd, IDepartment)
+from waeup.sirp.university.vocabularies import inst_types    
 
 class Faculty(grok.Container):
@@ -36 +37 @@
             del self[key]
 
-    #def getName(self, key):
-    #    """Get complete department name.
-    #    """
-    #    if key in self.keys():
-    #        dept = self[key]
-    #        prefix = dept.title_prefix
-    #        prefix = prefix[0].upper() + prefix[1:]
-    #        return '%s of %s' % (prefix, dept.title)
-
+    def longtitle(self):
+        return "%s %s (%s)" % (inst_types.getTerm(self.title_prefix).title, 
+                                                  self.title,
+                                                  self.code)
         
 class FacultyFactory(grok.GlobalUtility):

main/waeup.sirp/trunk/src/waeup/sirp/university/facultycontainer.py

@@ -22 +22 @@
             del self[key]
 
-    #def getName(self, key):
-    #    if key in self.keys():
-    #        fac = self[key]
-    #        prefix = fac.title_prefix
-    #        prefix = prefix[0].upper() + prefix[1:]
-    #        return '%s of %s' % (prefix, fac.title)
-            
 class FacultyContainerFactory(grok.GlobalUtility):
     """A factory for faculty containers.

main/waeup.sirp/trunk/src/waeup/sirp/university/interfaces.py

@@ -9 +9 @@
                                                 application_category, 
                                                 study_mode,
+                                                inst_types,
                                                 CourseSource)                                   
 
@@ -28 +29 @@
         )
 
-    title_prefix = schema.TextLine(
+    title_prefix = schema.Choice(
         title = u'Title prefix',
         default = u'faculty',
-        required = True,
-        )
+        vocabulary = inst_types,
+        required = True,
+        )
+        
+    def longtitle():
+        """
+        Returns the long title of a faculty.
+        """        
         
 class IFacultyAdd(IFaculty):
@@ -72 +79 @@
         )
 
-    title_prefix = schema.TextLine(
+    title_prefix = schema.Choice(
         title = u'Title prefix',
+        vocabulary = inst_types,
         default = u'department',
         required = True,
@@ -80 +88 @@
     courses = Attribute("A container for courses.")
     certificates = Attribute("A container for certificates.")
-
+    
+    def longtitle():
+        """
+        Returns the long title of a department.
+        """
+        
 class IDepartmentAdd(IDepartment):
     """Representation of a university department.

main/waeup.sirp/trunk/src/waeup/sirp/university/vocabularies.py

@@ -10 +10 @@
     from zope.app.catalog.interfaces import ICatalog
 from zope.component import getUtility
+
+inst_types = SimpleWAeUPVocabulary(
+             ('Faculty of','faculty'),
+             ('Department of','department'),
+             ('School of','school_of'),
+             ('School for','school_for'),
+             ('Institute of','institute'),
+             ('Office for','office'),
+             ('Centre for','centre'),
+             ('College','college'),
+             )
                                    
 course_levels = SimpleWAeUPVocabulary(

main/waeup.sirp/trunk/src/waeup/sirp/utils/helpers.py

@@ -118 +118 @@
             pass
     return html_code
-
-def getName(context):
-    """Construct a name out of an object with prefix and title.
-
-    The `context` has to provide `title_prefix` and `title`
-    attributes.
-
-        >>> from waeup.sirp.utils.helpers import getName
-        >>> class FakeObject(object):
-        ...     title_prefix = 'department'
-        ...     title = 'Strange Things'
-        >>> getName(FakeObject())
-        'Department of Strange Things'
-
-    As we can see in the result the `title_prefix` is rendered
-    uppercase.
-        
-    """
-    prefix = context.title_prefix
-    prefix = prefix[0].upper() + prefix[1:]
-    return '%s of %s' % (prefix, context.title)
 
 class FactoryBase(grok.GlobalUtility):