Changeset 5047

Timestamp:

11 Mar 2010, 13:16:37 (15 years ago)

Author:

uli

Message:

• Reorder imports (PEP 8)

• Check for KeyError? instead only DuplicationError? (API change in latest groktoolkit).

• BBB imports for old packages.

File:

• main/waeup.sirp/trunk/src/waeup/sirp/browser/pages.py (modified) (8 diffs)

main/waeup.sirp/trunk/src/waeup/sirp/browser/pages.py

@@ -10 +10 @@
 from hurry import yui
 from hurry.workflow.interfaces import NoTransitionAvailableError
+from zope import schema
+try:
+    from zope.authentication.interfaces import (
+        IAuthentication, IUnauthenticatedPrincipal, ILogout)
+except ImportError:
+    # BBB
+    from zope.app.security.interfaces import (
+        IAuthentication, IUnauthenticatedPrincipal, ILogout)
+from zope.component import (
+    getUtility, createObject,getAllUtilitiesRegisteredFor)
+from zope.component.interfaces import Invalid
+from zope.exceptions import DuplicationError
+from zope.session.interfaces import ISession
+
 from waeup.sirp.browser import (
     WAeUPPage, WAeUPEditFormPage, WAeUPAddFormPage,
@@ -16 +30 @@
     IUniversity, IFacultyContainer, IFaculty, IDepartment, ICourse,
     ICertificate, ICertificateCourse)
-from waeup.sirp.university.catalog import search
 from waeup.sirp.catalog import search_context
 from waeup.sirp.interfaces import(
     IWAeUPObject, IUserContainer, IUserAccount, IDataCenter,
-    IWAeUPXMLImporter, IWAeUPXMLExporter)
+    IWAeUPXMLImporter, IWAeUPXMLExporter, IBatchProcessor)
+from waeup.sirp.university.catalog import search
+from waeup.sirp.utils.helpers import getName
 from waeup.sirp.widgets.interfaces import ITableProvider
-from waeup.sirp.utils.helpers import getName
-from zope import schema
-from zope.app.security.interfaces import (
-    IAuthentication, IUnauthenticatedPrincipal, ILogout)
-from zope.component import getUtility, createObject
-from zope.component.interfaces import Invalid
-from zope.exceptions import DuplicationError
-from zope.session.interfaces import ISession
-
-from waeup.sirp.interfaces import IBatchProcessor
-from zope.component import getAllUtilitiesRegisteredFor
-
 
 grok.context(IWAeUPObject)
@@ -215 +218 @@
             self.context.addUser(name, password, title=title,
                                  description=description, roles=roles)
+        except KeyError:
+            self.status = Invalid('The userid chosen already exists '
+                                  'in the database')
+            return
         except DuplicationError:
             self.status = Invalid('The userid chosen already exists '
@@ -768 +775 @@
         try:
             self.context.addFaculty(faculty)
+        except KeyError:
+            self.status = Invalid('The name chosen already exists '
+                                  'in the database')
+            return
         except DuplicationError:
             self.status = Invalid('The name chosen already exists '
@@ -841 +852 @@
         try:
             self.context.addDepartment(department)
+        except KeyError:
+            self.status = Invalid('The code chosen already exists '
+                                  'in the database')
+            return
         except DuplicationError:
-            self.status = Invalid('The name chosen already exists '
+            self.status = Invalid('The code chosen already exists '
                                   'in the database')
             return
@@ -949 +964 @@
         try:
             self.context.courses.addCourse(course)
+        except KeyError:
+            self.status = Invalid('The code chosen already exists '
+                                  'in the database')
+            return
         except DuplicationError:
             self.status = Invalid('The code chosen already exists '
@@ -982 +1001 @@
         try:
             self.context.certificates.addCertificate(certificate)
+        except KeyError:
+            self.status = Invalid('The name chosen already exists '
+                                  'in the database')
+            return
         except DuplicationError:
             self.status = Invalid('The name chosen already exists '
@@ -1205 +1228 @@
         try:
             self.context.addCourseRef(**data)
+        except KeyError:
+            self.status = Invalid('The chosen course is already part of'
+                                  'this certificate')
+            return
         except DuplicationError:
             self.status = Invalid('The chosen course is already part of'