Changeset 4854 for waeup/branches/ulif-importers/src

Timestamp:

18 Jan 2010, 12:56:17 (15 years ago)

Author:

uli

Message:

Remove caching from CourseSource?. As functional tests turned out,
caching is evil in sources. We can get outdated references to
catalogs, objects etc. which can mean lots of hassle especially with
ZEO setups. So now we get a slightly increased processing time for
mass processing (import of 7.200 certcourses takes three seconds
longer), but that's acceptable compared to the problems arising
otherwise.

File:

• waeup/branches/ulif-importers/src/waeup/interfaces.py (modified) (1 diff)

waeup/branches/ulif-importers/src/waeup/interfaces.py

@@ -26 +26 @@
        up a catalog.
     """
-    catalog = None
-    _cached_values = None
     def getValues(self):
-        if self._cached_values is not None:
-            return self._cached_values
-        self.catalog = getUtility(ICatalog, name='courses_catalog')
-        self._cached_values = list(
-            self.catalog.searchResults(code=('', 'z*')))
-        return self._cached_values
+        catalog = getUtility(ICatalog, name='courses_catalog')
+        return list(catalog.searchResults(code=('', 'z*')))
 
     def getToken(self, value):