Changeset 4754

Timestamp:

9 Jan 2010, 11:11:51 (15 years ago)

Author:

uli

Message:

Fix workflow behaviour of certificates. These are the only
'workflowed' objects yet and I have to learn more about this.

File:

• waeup/branches/ulif-layout/src/waeup/university/certificate.py (modified) (3 diffs)

waeup/branches/ulif-layout/src/waeup/university/certificate.py

@@ -29 +29 @@
         self.max_pass = max_pass
         # Initialize workflow state...
-        self.setReviewState('init')
+        self.setReviewState('unchecked')
 
     def check(self):
@@ -39 +39 @@
         return IWorkflowState(self).getState()
 
-    def setReviewState(self, transition_id='check'):
+    def setReviewState(self, state=None):
+        """Try to set new state.
+
+        Instead of simply setting a value, we fire a transition of a
+        workflow. This might fail if, for instance, the required state
+        is not part of the workflow or unreachable from current state.
+        """
+        if state == self.getReviewState():
+            # Accept staying in the same state, even if workflow does
+            # not allow this.
+            return
         info = IWorkflowInfo(self)
-        info.fireTransition(transition_id)
+        info.fireTransitionToward(state)
         return
 
+    review_state = property(getReviewState, setReviewState)
+    
     def addCourseRef(self, course, level=100, core_or_elective=True):
         """Add a course reference.
@@ -66 +78 @@
         return
 
-    review_state = property(getReviewState, setReviewState)
+