Changeset 3135

Timestamp:

9 Feb 2008, 11:40:12 (17 years ago)

Author:

joachim

Message:

optimize mass_edit_verdict, exclude deactivated from pending.

File:

• WAeUP_SRP/base/WAeUPTool.py (modified) (2 diffs)

WAeUP_SRP/base/WAeUPTool.py

@@ -1974 +1974 @@
             return '',"no id or matric_no specified"
         student_id = student_record.id
-        student_obj = getattr(students_folder,student_id)
-        f2t = self.field2types_student
         d = {}
         #import pdb;pdb.set_trace()
@@ -1993 +1991 @@
                                                                                     student_record.level)
         student_review_state =  student_record.review_state
+        if student_review_state == 'deactivated':
+            return '',"student %s in review_state %s" % (student_id, student_review_state)
         if student_review_state not in ('courses_validated','returning'):
             return student_id,"student %s in wrong review_state %s" % (student_id, student_review_state)
+        student_obj = getattr(students_folder,student_id)
+        f2t = self.field2types_student
         study_course_obj = getattr(student_obj,'study_course',None)
         if study_course_obj is None: