Changeset 1996

Timestamp:

6 Jul 2007, 21:24:51 (17 years ago)

Author:

Henrik Bettermann

Message:

strange, strange, see my inline comments:

## No idea why the following lines were still active until July 6.
## The code does not make any sense. When editing the clearance object
## as admin, always the PIN HOS-1-4921190317
## was filled in. This was the only PIN ever used by admin.

File:

• WAeUP_SRP/trunk/skins/waeup_student/clearance_edit.py (modified) (2 diffs)

WAeUP_SRP/trunk/skins/waeup_student/clearance_edit.py

@@ -94 +94 @@
     if cpsdocument_edit_button or result_edit_button:
         psm = "Content changed!"
-        logger.info('%s edited clearance of %s' % (member_id,student_id ))
-        if clear_doc.clr_ac_pin == "":
-            res = context.portal_pins(student=member_id)
-            if res:
-                p = res[0].pin
-                if len(p) > 10:
-                    pin = "%s-%s-%s" % (p[:3],p[3:4],p[4:])
-                else:
-                    pin = p
-                clear_doc.edit(mapping={'clr_ac_pin': pin})
+        logger.info('%s edited clearance object of %s' % (member_id,student_id ))
+
+        ## No idea why the following lines were still active until July 6.
+        ## The code does not make any sense. When editing the clearance object 
+        ## as admin, always the PIN HOS-1-4921190317
+        ## was filled in. This was the only PIN ever used by admin.
+        
+        #if clear_doc.clr_ac_pin == "":
+        #    res = context.portal_pins(student=member_id)
+        #    if res:
+        #        p = res[0].pin
+        #        if len(p) > 10:
+        #            pin = "%s-%s-%s" % (p[:3],p[3:4],p[4:])
+        #        else:
+        #            pin = p
+        #        clear_doc.edit(mapping={'clr_ac_pin': pin})
+
+        ## simple method to remove the wrong PIN
+        
+        #if clear_doc.clr_ac_pin.startswith('HOS'):
+        #    pin=''
+        #    clear_doc.edit(mapping={'clr_ac_pin': pin})
+
+
     elif cpsdocument_edit_and_view_button:
         if acknowledge and info['review_state'] == "clearance_pin_entered":
@@ -134 +148 @@
     psm = "Please correct your errors!"
     args = getFormUidUrlArg(REQUEST)
-    logger.info('%s got error when editing %s' % (member_id,student_id))
+    logger.info('%s got error when editing the clearance object of %s' % (member_id,student_id))
 
 args['portal_status_message'] = psm