Changeset 17985 for main

Timestamp:

16 Jan 2025, 02:08:45 (8 hours ago)

Author:

Henrik Bettermann

Message:

CreateAllStudentsPage: Stop creation after 1000 students to avoid write
conflicts which sill occur even though transactions have formerly been
commited.

Location:

main/waeup.kofa/trunk

Files:

• CHANGES.txt (modified) (1 diff)
• src/waeup/kofa/applicants/browser.py (modified) (2 diffs)
• src/waeup/kofa/applicants/browser_templates/createallstudentspage.pt (modified) (1 diff)
• src/waeup/kofa/applicants/tests/test_applicantcopier.py (modified) (2 diffs)

main/waeup.kofa/trunk/CHANGES.txt

@@ -4 +4 @@
 1.8.2.dev0 (unreleased)
 =======================
+
+* `CreateAllStudentsPage`: Stop creation after 1000 students to avoid write 
+  conflicts which sill occur even though transactions have formerly been 
+  commited.
 
 * Implement `ExportPDFFinalClearanceSlip`.

main/waeup.kofa/trunk/src/waeup/kofa/applicants/browser.py

@@ -775 +775 @@
         n = 0
         for result in results:
-            n += 1
             if container_only and result.__parent__ is not self.context:
                 continue
+            n += 1
             success, msg = result.createStudent(view=self)
             if success:
@@ -785 +785 @@
                     (result.applicant_id, self.url(result, 'manage'), msg))
             if not n % 1000:
-                transaction.commit()
+                # Stop after 1000 students to avoid write conflicts which sill
+                # occur even though transactions have formerly been commited.
+                break
+        self.flash(_('Finished.'))
         grok.getSite()['configuration'].maintmode_enabled_by = None
+        self.n = n
         self.successful = ', '.join(created)
         self.failed = failed

main/waeup.kofa/trunk/src/waeup/kofa/applicants/browser_templates/createallstudentspage.pt

@@ -1 +1 @@
 <div i18n:domain="waeup.kofa">
-  <tal:success condition="view/successful">
-    <strong i18n:translate="">Successfully created records:</strong>
-    <br />
-    <div  tal:replace="structure view/successful">
-    </div>
-    <br />
-  </tal:success>
+  <span i18n:translate="">
+    <span i18n:name="n" tal:replace="view/n">N</span> student records have been successfully created.
+  </span>
+  <br />
   <tal:fail condition="view/failed">
     <strong i18n:translate="">Failed records:</strong>

main/waeup.kofa/trunk/src/waeup/kofa/applicants/tests/test_applicantcopier.py

@@ -303 +303 @@
         self.browser.open(self.container_path + '/createallstudents')
         self.assertFalse('Failed records' in self.browser.contents)
-        self.assertTrue('Successfully created records' in self.browser.contents)
+        self.assertTrue('1 student records have been successfully created.' in self.browser.contents)
         logcontent = open(logfile).read()
         self.assertTrue('applicants.browser.CreateAllStudentsPage - started in app%s' % session
@@ -328 +328 @@
         self.applicant.course_admitted = self.certificate
         self.browser.open(self.root_path + '/createallstudents')
-        self.assertTrue('Successfully created records:' in self.browser.contents)
+        self.assertTrue('1 student records have been successfully created.' in self.browser.contents)
         logcontent = open(logfile).read()
         self.assertTrue('applicants.browser.CreateAllStudentsPage - started in applicants'