Changeset 17811 for main/kofacustom.nigeria/trunk/src

Timestamp:

6 Jun 2024, 11:11:23 (5 months ago)

Author:

Henrik Bettermann

Message:

Use allowPortraitChange utility method.

Location:

main/kofacustom.nigeria/trunk/src/kofacustom/nigeria/students

Files:

• browser.py (modified) (1 diff)
• utils.py (modified) (2 diffs)
• viewlets.py (modified) (1 diff)

main/kofacustom.nigeria/trunk/src/kofacustom/nigeria/students/browser.py

@@ -248 +248 @@
         'flash_notice')
 
-class NigeriaStudentFilesUploadPage(StudentFilesUploadPage):
-    """ View to upload passport picture.
-
-    Students are not allowed to change the picture if they
-    passed the regular Kofa application.
-    """
-
-    def update(self):
-        # Passport pictures must not be editable if application slip
-        # exists.
-        slip = getUtility(IExtFileStore).getFileByContext(
-            self.context, 'application_slip')
-        PORTRAIT_CHANGE_STATES = getUtility(IStudentsUtils).PORTRAIT_CHANGE_STATES
-        if self.context.state not in PORTRAIT_CHANGE_STATES or slip is not None:
-            emit_lock_message(self)
-            return
-        return
-
 class ClearStudentFinancially(UtilityView, grok.View):
     """ Clear student financially by financial clearance officer

main/kofacustom.nigeria/trunk/src/kofacustom/nigeria/students/utils.py

@@ -17 +17 @@
 ##
 import grok
+from zope.component import getUtility
+from waeup.kofa.interfaces import IExtFileStore
 from waeup.kofa.students.utils import StudentsUtils
 from kofacustom.nigeria.interfaces import MessageFactory as _
@@ -41 +43 @@
     # Maximum size of upload files in kB
     MAX_KB = 250
+
+    def allowPortraitChange(self, student):
+        """Check if student is allowed to change the portrait file.
+        """
+        # Passport pictures must not be editable if application slip
+        # exists. Students are not allowed to change the picture if they passed
+        # the regular Kofa application.
+        slip = getUtility(IExtFileStore).getFileByContext(
+            student, 'application_slip')
+        if student.state not in self.PORTRAIT_CHANGE_STATES or slip is not None:
+            return False
+        return True
+

main/kofacustom.nigeria/trunk/src/kofacustom/nigeria/students/viewlets.py

@@ -41 +41 @@
     return False
 
-class StudentPassportActionButton(StudentPassportActionButton):
-
-    @property
-    def target_url(self):
-        # Passport pictures must not be editable if application slip
-        # exists.
-        slip = getUtility(IExtFileStore).getFileByContext(
-            self.context, 'application_slip')
-        PORTRAIT_CHANGE_STATES = getUtility(IStudentsUtils).PORTRAIT_CHANGE_STATES
-        if self.context.state not in PORTRAIT_CHANGE_STATES or slip is not None:
-            return ''
-        return self.view.url(self.view.context, self.target)
-
 class PaymentReceiptActionButton(PaymentReceiptActionButton):
     grok.order(4)